-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[femutils] BSR Matrix Storage Format #198
Draft
toutane
wants to merge
27
commits into
arcaneframework:main
Choose a base branch
from
toutane:dev/cal-femutils-bsr-format
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[femutils] BSR Matrix Storage Format #198
toutane
wants to merge
27
commits into
arcaneframework:main
from
toutane:dev/cal-femutils-bsr-format
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poisson, it is used for 2D and 3D, for elasticity, only 2D is supported.
Elasticity modules
fem-utils functions in more specific namespaces
rm[femutils]: remove empty BSRFormat.cc clean[femutils]: clean poisson clean[elasticity]: refactor cleam[femutils]: add comments feat[femutils]: compute nz per row array on gpu
grospelliergilles
approved these changes
Dec 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
+ Coverage 70.69% 70.71% +0.01%
==========================================
Files 56 58 +2
Lines 8391 8836 +445
Branches 1006 1049 +43
==========================================
+ Hits 5932 6248 +316
- Misses 2176 2293 +117
- Partials 283 295 +12 ☔ View full report in Codecov by Sentry. |
toutane
force-pushed
the
dev/cal-femutils-bsr-format
branch
from
December 20, 2024 15:39
bc53bb0
to
7950de9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the BSR Sparse Matrix Storage Format into ArcaneFem
Femutils
library.The implementation is composed of two classes:
BSRMatrix: stores the non-zero coefficients of a matrix within three arrays:
values
,columns
androw_index
. It provides a simple interface to handle coefficients, convert to CSR format and translate to linear system.BSRFormat: provide functions to assemble a BSR matrix from mesh informations. Supports meshes with multiple degrees-of-freedom. Uses a
BSRMatrix
under the hood. Most of functions use GPU via Arcane accelerator API. Matrix assembly can be done "cell-wise" (with the use of an atomic operation) or "node-wise" for both triangular and tetrahedral elements. It is designed to be used by ArcaneFem modules.This pull request demonstrates the use of the new
BSRMatrix
andBSRFormat
classes within two modules:Poisson
(1 DoF, 2D & 3D) andElasticity
(2 DoFs, 2D). Thebsr
option can be pass to.arc
files to enable its use. Tests have been added for those modules.