Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundled version of googletest for Arccore #1202

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

grospelliergilles
Copy link
Member

This will help to make sure googletest use the same compilation options than Arccore.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 15.69507% with 188 lines in your changes are missing coverage. Please review.

Project coverage is 68.38%. Comparing base (59423f1) to head (cc67d33).
Report is 1 commits behind head on main.

Files Patch % Lines
...ogletest/googletest/include/gtest/gtest-printers.h 0.00% 97 Missing ⚠️
...ogletest/include/gtest/internal/gtest-param-util.h 0.00% 29 Missing ⚠️
...extras/googletest/googletest/include/gtest/gtest.h 34.37% 19 Missing and 2 partials ⚠️
...oogletest/include/gtest/internal/gtest-type-util.h 0.00% 17 Missing ⚠️
.../googletest/include/gtest/gtest-assertion-result.h 18.18% 9 Missing ⚠️
...oogletest/googletest/include/gtest/gtest-message.h 0.00% 6 Missing ⚠️
...googletest/include/gtest/internal/gtest-internal.h 81.48% 4 Missing and 1 partial ⚠️
...est/googletest/include/gtest/internal/gtest-port.h 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
- Coverage   68.46%   68.38%   -0.08%     
==========================================
  Files        2050     2058       +8     
  Lines      149478   149701     +223     
  Branches    17243    17274      +31     
==========================================
+ Hits       102337   102379      +42     
- Misses      41011    41190     +179     
- Partials     6130     6132       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles force-pushed the dev/gg-add-bundled-googletest branch from cadcb76 to cc67d33 Compare June 2, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant