Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IMesh in mesh exchange tools #1841

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Conversation

stdcm
Copy link
Member

@stdcm stdcm commented Dec 13, 2024

  • MeshExchangeMng and MeshExchanger were using DynamicMesh*.
  • Move to IMesh* to be used in PolyhedralMesh.

@stdcm stdcm self-assigned this Dec 13, 2024
@stdcm stdcm added arcane Arcane Component refactoring Code refactoring and cleanup labels Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.20%. Comparing base (78e8513) to head (6108aa3).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...e/src/arcane/core/internal/IMeshModifierInternal.h 0.00% 1 Missing ⚠️
arcane/src/arcane/mesh/MeshExchangeMng.cc 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1841   +/-   ##
=======================================
  Coverage   70.20%   70.20%           
=======================================
  Files        2263     2263           
  Lines      163033   163035    +2     
  Branches    18787    18787           
=======================================
+ Hits       114463   114465    +2     
- Misses      41776    41777    +1     
+ Partials     6794     6793    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@grospelliergilles grospelliergilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to remove usage of the implementation DynamicMesh.

@stdcm stdcm merged commit cd59698 into main Dec 13, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane Arcane Component refactoring Code refactoring and cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants