Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialization of new types 'Float128' and 'Int128' #1867

Merged
merged 4 commits into from
Dec 24, 2024

Conversation

grospelliergilles
Copy link
Member

Also make usage of ISerializer::eDataType deprecated. People should use type eBasicDataType instead.

@grospelliergilles grospelliergilles added enhancement New feature or request arccore Arccore component labels Dec 24, 2024
@grospelliergilles grospelliergilles self-assigned this Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 83.47578% with 58 lines in your changes missing coverage. Please review.

Project coverage is 70.34%. Comparing base (431836a) to head (a4e2dfc).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...src/serialize/arccore/serialize/BasicSerializer.cc 81.69% 45 Missing and 7 partials ⚠️
...essage_passing/arccore/message_passing/Messages.cc 66.66% 2 Missing and 2 partials ⚠️
arccore/src/base/arccore/base/ValueFiller.h 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1867      +/-   ##
==========================================
+ Coverage   70.29%   70.34%   +0.04%     
==========================================
  Files        2272     2272              
  Lines      163556   163745     +189     
  Branches    18856    18861       +5     
==========================================
+ Hits       114976   115187     +211     
+ Misses      41758    41736      -22     
  Partials     6822     6822              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit c994e67 into main Dec 24, 2024
31 of 32 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-add-new-types-to-serializer branch December 27, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arccore Arccore component enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant