Move some mathematical methods of 'Real2', 'Real3', 'Real2x2' and 'Real3x3' in namespace 'math' #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, 'Real2x2' et 'Real3x3' dans le namespace 'math'. Les méthodes déplacées sont 'isNearlyZero()', 'normL2()', 'squareNormL2()' et 'normalize()'. Cela permet de les appeler de manière cohérente avec les autres types de données.
grospelliergilles
added
arcane
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1871 +/- ##
==========================================
+ Coverage 70.26% 70.30% +0.03%
==========================================
Files 2272 2272
Lines 163761 163781 +20
Branches 18855 18863 +8
==========================================
+ Hits 115071 115145 +74
+ Misses 41861 41810 -51
+ Partials 6829 6826 -3 ☔ View full report in Codecov by Sentry. |
grospelliergilles
deleted the
dev/gg-move-math-methods-outside-of-realn
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The moved methods are
isNearlyZero(),normL2(),squareNormL2()etnormalize().This will allow us to use these methods the same way for any type.