Split explicit instantiation of 'ArrayData' and 'Array2Data' in several files #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NUMERIC_DATATYPE' en trois parties pour instantier en 3 fois. Cela permet de répartir la compilation sur plusieurs fichiers et de l'accélérer.
Supprime aussi les fichiers 'ArrayData.h' et 'Array2Data.h' plus utilisés.
…IC_DATATYPE' pour 'ScalarData'.
grospelliergilles
added
arcane
grospelliergilles
force-pushed
the
dev/gg-separate-some-template-explicit-instantiation
branch
from
997f5e6 to
c4f4c58
Compare
grospelliergilles
force-pushed
the
dev/gg-separate-some-template-explicit-instantiation
branch
from
c4f4c58 to
34e8d08
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1873 +/- ##
==========================================
- Coverage 70.30% 70.26% -0.04%
==========================================
Files 2272 2276 +4
Lines 163777 163773 -4
Branches 18863 18857 -6
==========================================
- Hits 115142 115074 -68
- Misses 41809 41869 +60
- Partials 6826 6830 +4 ☔ View full report in Codecov by Sentry. |
grospelliergilles
deleted the
dev/gg-separate-some-template-explicit-instantiation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to speed-up the compilation of these files.
With these modification, it take 3x7s instead of 20s.