Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor usage of accelerator API for constituents and add documentation #1875

Merged
merged 4 commits into from
Dec 28, 2024

Conversation

grospelliergilles
Copy link
Member

  • Use template classes for common commands on materials and environments
  • Add explicit classes for iterator values
  • Add documentation

…lCellIteratorValue' pour les RunCommand sur les matériaux et les milieux.
… classes communes aux matériaux et milieux.
@grospelliergilles grospelliergilles added documentation Improvements or additions to documentation arcane Arcane Component refactoring Code refactoring and cleanup arcane:accelerator Arcane Accelerator API/Runtime arcane:materials Management of Constituents (Material/Environment) labels Dec 28, 2024
@grospelliergilles grospelliergilles self-assigned this Dec 28, 2024
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

Attention: Patch coverage is 96.05263% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.28%. Comparing base (0c1e453) to head (a185294).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/arcane/accelerator/RunCommandMaterialEnumerate.h 94.73% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1875      +/-   ##
==========================================
- Coverage   70.29%   70.28%   -0.01%     
==========================================
  Files        2275     2275              
  Lines      163780   163762      -18     
  Branches    18863    18863              
==========================================
- Hits       115124   115102      -22     
- Misses      41829    41831       +2     
- Partials     6827     6829       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit d17dfd1 into main Dec 28, 2024
31 of 32 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-simplify-runcommandmatenumerate branch December 31, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane:accelerator Arcane Accelerator API/Runtime arcane:materials Management of Constituents (Material/Environment) arcane Arcane Component documentation Improvements or additions to documentation refactoring Code refactoring and cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant