Make CMake option ARCANE_ADD_RPATH_TO_LIBS off by default #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BS'. Cette option était utilisée avec les CMake anciens où il n'y avait pas la transitivité des cibles. Cette option ne supporte par les mécanismes modernes tels que les 'generator expression'. Normalement elle n'est plus utilisée donc on pourra la supprimer fin 2024.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #919 +/- ##
==========================================
- Coverage 71.46% 71.45% -0.01%
==========================================
Files 1972 1972
Lines 143316 143316
==========================================
- Hits 102414 102410 -4
- Misses 40902 40906 +4 ☔ View full report in Codecov by Sentry. |
grospelliergilles
deleted the
dev/gg-make-config-add-rpath-off-by-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was used to automatically add 'rpath' arguments for linker from target libname.
This is not needed with modern CMake and it does not work with 'generator expression'.
It will be removed next year.