-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spi support #199
Open
austinscreations
wants to merge
4
commits into
arduino-libraries:master
Choose a base branch
from
austinscreations:add-SPI-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add spi support #199
austinscreations
wants to merge
4
commits into
arduino-libraries:master
from
austinscreations:add-SPI-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory usage change @ f00f1f1
Click for full report table
Click for full report CSV
|
per1234
added
topic: code
Related to content of the project itself
type: enhancement
Proposed improvement
labels
Jun 14, 2022
Memory usage change @ 7a418d3
Click for full report table
Click for full report CSV
|
found glitches when using the changes I had made and was being used in a project. i've now found all the |
Memory usage change @ ed44f42
Click for full report table
Click for full report CSV
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ok, reopening a request for this.
figured out my platformIO install wasn't linked correctly to my github and wasn't signing commits correctly.
and the previous automatic checks showed i had issues with AVR and SAMD support - both of which should be fixed now.
the main reason i started these changes was to give VSPI and HSPI support to esp32, specifically the WT32-SC01 touchscreen has the display on HSPI and adding Ethernet was having conflicts, this code fixes that. but there is also an implementation to define the SPI pins with build defines in platformIO so that different pins can be used (which is also useful for the touchscreen)
i've tested this code on esp32 and esp8266 but don't have any AVR hardware on hand to test with. (but this should pass compile checks)