DhcpAddressPrinter example: Fix initialization with no hardware present #247

hansu · 2024-01-10T09:49:45Z

Error message about not present Ethernet hardware was only printed if mac==0, which makes not really sense:

  if (Ethernet.begin(mac) == 0) {
    Serial.println("Failed to configure Ethernet using DHCP");
    if (Ethernet.hardwareStatus() == EthernetNoHardware) {
      Serial.println("Ethernet shield was not found.  Sorry, can't run without hardware. :(");
    }

github-actions · 2024-01-25T08:12:46Z

Memory usage change @ 064a37d

Board	flash	%	RAM for global variables	%
`arduino:avr:leonardo`	🔺 0 - +10	0.0 - +0.03	0 - 0	0.0 - 0.0
`arduino:avr:mega`	🔺 0 - +6	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:avr:nano`	🔺 0 - +8	0.0 - +0.03	0 - 0	0.0 - 0.0
`arduino:megaavr:nona4809`	🔺 0 - +20	0.0 - +0.04	0 - 0	0.0 - 0.0
`arduino:megaavr:uno2018`	🔺 0 - +20	0.0 - +0.04	0 - 0	0.0 - 0.0
`arduino:sam:arduino_due_x_dbg`	0 - 0	0.0 - 0.0	N/A	N/A
`arduino:samd:arduino_zero_edbg`	🔺 0 - +8	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkr1000`	🔺 0 - +4	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrfox1200`	🔺 0 - +4	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrgsm1400`	🔺 0 - +4	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrnb1500`	🔺 0 - +4	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrvidor4000`	🔺 0 - +4	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwan1300`	🔺 0 - +4	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwan1310`	🔺 0 - +4	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwifi1010`	🔺 0 - +4	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrzero`	🔺 0 - +4	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:nano_33_iot`	🔺 0 - +4	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/AdvancedChatServer` RAM for global variables	%	`examples/BarometricPressureWebServer` RAM for global variables	%	`examples/ChatServer` RAM for global variables	%	`examples/DhcpAddressPrinter` flash	%	`examples/DhcpAddressPrinter` RAM for global variables	%	`examples/DhcpChatServer` RAM for global variables	%	`examples/LinkStatus` RAM for global variables	%	`examples/PagerServer` RAM for global variables	%	`examples/TelnetClient` RAM for global variables	%	`examples/UDPSendReceiveString` RAM for global variables	%	`examples/UdpNtpClient` RAM for global variables	%	`examples/WebClient` RAM for global variables	%	`examples/WebClientRepeating` RAM for global variables	%	`examples/WebServer` RAM for global variables	%
`arduino:avr:leonardo`	0	0.0	0	0.0	0	0.0	10	0.03	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:avr:mega`	0	0.0	0	0.0	0	0.0	6	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:avr:nano`	0	0.0	0	0.0	0	0.0	8	0.03	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:megaavr:nona4809`	0	0.0	0	0.0	0	0.0	20	0.04	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:megaavr:uno2018`	0	0.0	0	0.0	0	0.0	20	0.04	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:sam:arduino_due_x_dbg`	N/A	N/A	N/A	N/A	N/A	N/A	0	0.0	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
`arduino:samd:arduino_zero_edbg`	0	0.0	0	0.0	0	0.0	8	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkr1000`	0	0.0	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrfox1200`	0	0.0	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrgsm1400`	0	0.0	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrnb1500`	0	0.0	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrvidor4000`	0	0.0	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwan1300`	0	0.0	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwan1310`	0	0.0	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwifi1010`	0	0.0	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrzero`	0	0.0	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:nano_33_iot`	0	0.0	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/AdvancedChatServer<br>flash,%,examples/AdvancedChatServer<br>RAM for global variables,%,examples/BarometricPressureWebServer<br>flash,%,examples/BarometricPressureWebServer<br>RAM for global variables,%,examples/ChatServer<br>flash,%,examples/ChatServer<br>RAM for global variables,%,examples/DhcpAddressPrinter<br>flash,%,examples/DhcpAddressPrinter<br>RAM for global variables,%,examples/DhcpChatServer<br>flash,%,examples/DhcpChatServer<br>RAM for global variables,%,examples/LinkStatus<br>flash,%,examples/LinkStatus<br>RAM for global variables,%,examples/PagerServer<br>flash,%,examples/PagerServer<br>RAM for global variables,%,examples/TelnetClient<br>flash,%,examples/TelnetClient<br>RAM for global variables,%,examples/UDPSendReceiveString<br>flash,%,examples/UDPSendReceiveString<br>RAM for global variables,%,examples/UdpNtpClient<br>flash,%,examples/UdpNtpClient<br>RAM for global variables,%,examples/WebClient<br>flash,%,examples/WebClient<br>RAM for global variables,%,examples/WebClientRepeating<br>flash,%,examples/WebClientRepeating<br>RAM for global variables,%,examples/WebServer<br>flash,%,examples/WebServer<br>RAM for global variables,%
arduino:avr:leonardo,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,10,0.03,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:avr:mega,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,6,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:avr:nano,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,8,0.03,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:megaavr:nona4809,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,20,0.04,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:megaavr:uno2018,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,20,0.04,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:sam:arduino_due_x_dbg,0,0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A
arduino:samd:arduino_zero_edbg,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrfox1200,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrvidor4000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1310,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrzero,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

CLAassistant · 2024-03-21T18:17:51Z

All committers have signed the CLA.

hansu · 2024-07-16T19:52:07Z

Is there anything that keep this PR from being merged?

hansu · 2025-01-02T16:16:20Z

Almost a year passed ... so it seems that my PR is not of interest. If that is so, I will delete my fork at the end of the month.

DhcpAddressPrinter example: Fix initialization with no hardware present

064a37d

per1234 added topic: documentation Related to documentation for the project type: imperfection Perceived defect in any part of project labels Jan 10, 2024

arduino-libraries deleted a comment from github-actions bot Jan 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DhcpAddressPrinter example: Fix initialization with no hardware present #247

DhcpAddressPrinter example: Fix initialization with no hardware present #247

hansu commented Jan 10, 2024

github-actions bot commented Jan 25, 2024

CLAassistant commented Mar 21, 2024 •

edited

Loading

hansu commented Jul 16, 2024

hansu commented Jan 2, 2025

DhcpAddressPrinter example: Fix initialization with no hardware present #247

Are you sure you want to change the base?

DhcpAddressPrinter example: Fix initialization with no hardware present #247

Conversation

hansu commented Jan 10, 2024

github-actions bot commented Jan 25, 2024

CLAassistant commented Mar 21, 2024 • edited Loading

hansu commented Jul 16, 2024

hansu commented Jan 2, 2025

CLAassistant commented Mar 21, 2024 •

edited

Loading