Fixed file checkpointing tests and added crate tests to CI

argmin-rs · Jan 18, 2024 · 8ed3b25 · 8ed3b25
1 parent 6936aa0
commit 8ed3b25
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 8 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -52,6 +52,15 @@ jobs:
       - name: Test 
         run: cargo test -p argmin-observer-paramwriter
 
+  tests-argmin-checkpointing-file:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: Swatinem/rust-cache@v2
+      - uses: dtolnay/rust-toolchain@stable
+      - name: Test 
+        run: cargo test -p argmin-checkpointing-file
+
   tests-argmin-observer-spectator:
     runs-on: ubuntu-latest
     steps:

diff --git a/argmin/src/core/executor.rs b/argmin/src/core/executor.rs
@@ -570,7 +570,6 @@ mod tests {
 
     /// The solver's `init` should not be called when started from a checkpoint.
     /// See https://github.com/argmin-rs/argmin/issues/199.
-    // #[cfg(feature = "serde1")]
     #[test]
     #[cfg(feature = "serde1")]
     fn test_checkpointing_solver_initialization() {

diff --git a/checkpointing/file/Cargo.toml b/checkpointing/file/Cargo.toml
@@ -17,3 +17,6 @@ exclude = []
 argmin = { version = "0.9.0", path = "../../argmin", default-features = false }
 bincode = "1.3.3"
 serde = "1.0.195"
+
+[dev-dependencies]
+argmin = { version = "0.9.0", path = "../../argmin", features = ["serde1"] }
diff --git a/checkpointing/file/checkpoints/solver.arg b/checkpointing/file/checkpoints/solver.arg
diff --git a/checkpointing/file/src/lib.rs b/checkpointing/file/src/lib.rs
@@ -32,7 +32,7 @@ impl Default for FileCheckpoint {
     /// # Example
     ///
     /// ```
-    /// use argmin::core::checkpointing::FileCheckpoint;
+    /// use argmin_checkpointing_file::FileCheckpoint;
     /// # use argmin::core::checkpointing::CheckpointingFrequency;
     /// # use std::path::PathBuf;
     ///
@@ -56,8 +56,7 @@ impl FileCheckpoint {
     /// # Example
     ///
     /// ```
-    /// use argmin::core::checkpointing::CheckpointingFrequency;
-    /// use argmin_checkpointing_file::FileCheckpoint;
+    /// use argmin_checkpointing_file::{FileCheckpoint, CheckpointingFrequency};
     /// # use std::path::PathBuf;
     ///
     /// let directory = "checkpoints";
@@ -93,8 +92,7 @@ where
     /// # Example
     ///
     /// ```
-    /// use argmin::core::checkpointing::CheckpointingFrequency;
-    /// use argmin_checkpointing_file::FileCheckpoint;
+    /// use argmin_checkpointing_file::{FileCheckpoint, CheckpointingFrequency, Checkpoint};
     ///
     /// # use std::fs::File;
     /// # use std::io::BufReader;
@@ -129,8 +127,7 @@ where
     /// # Example
     ///
     /// ```
-    /// use argmin::core::checkpointing::CheckpointingFrequency;
-    /// use argmin_checkpointing_file::FileCheckpoint
+    /// use argmin_checkpointing_file::{FileCheckpoint, CheckpointingFrequency, Checkpoint};
     /// # use argmin::core::Error;
     ///
     /// # use std::fs::File;