Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn examples into crates #387

Merged
merged 8 commits into from
Jan 15, 2024
Merged

Conversation

stefan-k
Copy link
Member

@stefan-k stefan-k commented Jan 14, 2024

Closes #307

  • Port all examples
  • Adapt all examples links in docs
  • adapt docs

notes

  • wasm32-unknown-emscripten build fails on new examples because "emcc" cannot be found. This is why examples are now excluded from that build. To make this easier, examples are named "example-".
  • Also wasm32-unknown-unknown fails when intel-mkl is involved. I have deactivated the examples in the wasm CI builds.

@stefan-k stefan-k self-assigned this Jan 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (26c7d68) 90.16% compared to head (ed489c8) 90.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
+ Coverage   90.16%   90.25%   +0.08%     
==========================================
  Files         141      141              
  Lines       19679    19679              
==========================================
+ Hits        17744    17761      +17     
+ Misses       1935     1918      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan-k stefan-k merged commit 8a9f7d4 into argmin-rs:main Jan 15, 2024
16 checks passed
@stefan-k stefan-k deleted the examples_as_crates branch January 15, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn examples into crates
2 participants