Adds podman compatibility in makefile #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author: Elias Rami <[email protected]> Date: Sun Apr 7 19:11:24 2024 +0200 Signed-off-by: Elias Rami <[email protected]>
Elyytscha
force-pushed
the
feat/podman-compat
branch
from
d404efa to
7312ca0
Compare
svghadi
requested changes
May 16, 2024
There was a problem hiding this comment.
Thank You @Elyytscha for the PR. I have a minor suggestion, other than that look good.
…installed Author: Elias Rami <[email protected]> Date: Mon May 27 17:09:22 2024 +0200 Signed-off-by: Elias Rami <[email protected]>
Elyytscha
force-pushed
the
feat/podman-compat
branch
from
5705dbf to
b748f84
Compare
svghadi
approved these changes
May 29, 2024
|
feel free to squash it, if it gets merged, does not need to be 2 commits imo. |
|
Thanks @Elyytscha for the contribution. |
svghadi
added
the
backport-to-redesign
svghadi
pushed a commit
to svghadi/argocd-operator
that referenced
this pull request
Jun 20, 2024
* feat: podman compatibility in makefile Author: Elias Rami <[email protected]> Date: Sun Apr 7 19:11:24 2024 +0200 Signed-off-by: Elias Rami <[email protected]> * fix: throw warning instead of error when neither podman or docker is installed Author: Elias Rami <[email protected]> Date: Mon May 27 17:09:22 2024 +0200 Signed-off-by: Elias Rami <[email protected]> --------- Signed-off-by: Elias Rami <[email protected]>
svghadi
removed
the
backport-to-redesign
svghadi
added a commit
that referenced
this pull request
Jun 20, 2024
) * docs: Add documentation for Appsets in any namespace (#1249) * Add documentation for Appsets in any namespace --------- Signed-off-by: Siddhesh Ghadi <[email protected]> * docs: fix broken link in openshift.md (#1282) Signed-off-by: Birger J. Nordølum <[email protected]> * Adds podman compatibility in makefile (#1299) * feat: podman compatibility in makefile Author: Elias Rami <[email protected]> Date: Sun Apr 7 19:11:24 2024 +0200 Signed-off-by: Elias Rami <[email protected]> * fix: throw warning instead of error when neither podman or docker is installed Author: Elias Rami <[email protected]> Date: Mon May 27 17:09:22 2024 +0200 Signed-off-by: Elias Rami <[email protected]> --------- Signed-off-by: Elias Rami <[email protected]> * add updated instructions to release process doc (#1314) * Update mkdocs requirements.txt based on argo cd dependencies (#1351) Signed-off-by: Jonathan West <[email protected]> * Automatically download correct operator-sdk version to bin dir, if not found (#1396) * Automatically download correct operator-sdk version to bin dir, if not found Signed-off-by: Jonathan West <[email protected]> * Automatically download correct operator-sdk version to bin dir, if not found Signed-off-by: Jonathan West <[email protected]> --------- Signed-off-by: Jonathan West <[email protected]> --------- Signed-off-by: Siddhesh Ghadi <[email protected]> Signed-off-by: Birger J. Nordølum <[email protected]> Signed-off-by: Elias Rami <[email protected]> Signed-off-by: Jonathan West <[email protected]> Co-authored-by: Birger J. Nordølum <[email protected]> Co-authored-by: Elias Rami <[email protected]> Co-authored-by: Regina Scott <[email protected]> Co-authored-by: Jonathan West <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
Adds Podman compatibility to Makefile
Have you updated the necessary documentation?
I think no doc update is needed for this
Which issue(s) this PR fixes:
Fixes #1298
How to test changes / Special notes to the reviewer:
with podman or docker installed, both will work