feat: Add support for custom ClusterRoles (controller,server) for cluster scoped instances #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparsai
changed the title
svghadi
reviewed
May 22, 2024
jparsai
changed the title
jgwest
requested changes
May 23, 2024
There was a problem hiding this comment.
Looks great, just some minor stuff I could think of re: expected user behaviour.
EDIT: kuttl tests for this use case are blocked due to need to set env var, so ignore this: One more request: can you add a simple kuttl test that sets ?DefaultClusterScopedRoleCreationDisabled to true, and ensures that ClusterRole/ClusterRoleBinding are not created
Signed-off-by: Jayendra Parsai <[email protected]>
Signed-off-by: Jonathan West <[email protected]>
jgwest
approved these changes
May 24, 2024
reginapizza
pushed a commit
to reginapizza/argocd-operator
that referenced
this pull request
Jun 5, 2024
…ster scoped instances (argoproj-labs#1357) * feat: Enable use of alternate cluster roles for cluster scoped instances Signed-off-by: Jayendra Parsai <[email protected]> * Update role/binding unit tests, add a new line to the doc Signed-off-by: Jonathan West <[email protected]> --------- Signed-off-by: Jayendra Parsai <[email protected]> Signed-off-by: Jonathan West <[email protected]> Co-authored-by: Jayendra Parsai <[email protected]> Co-authored-by: Jonathan West <[email protected]>
svghadi
added
the
backport-to-redesign
svghadi
removed
the
backport-to-redesign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
This PR enables user to define custom roles for cluster scoped instances of Argo CD. This is becoming increasingly important with the addition of the auto-respect RBAC feature added in Argo CD 2.10.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #1275
Note this also tracked in Red Hat's issue database here: https://issues.redhat.com/browse/GITOPS-2614
How to test changes / Special notes to the reviewer:
ARGOCD_CLUSTER_CONFIG_NAMESPACESenvironment variable of Subscription resource.Spec.DefaultClusterScopedRoleCreationDisabledtotrue.