Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use testify instead of testing.Fatal #21258

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

Description

  • uses testify instead of testing.Fatal

@mmorel-35 mmorel-35 requested a review from a team as a code owner December 19, 2024 09:36
Copy link

bunnyshell bot commented Dec 19, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@pasha-codefresh
Copy link
Member

Thank you! This is very important work

@pasha-codefresh
Copy link
Member

@mmorel-35 could you please check, tests fails due to your changes

@mmorel-35 mmorel-35 marked this pull request as draft December 19, 2024 09:51
@pasha-codefresh pasha-codefresh self-requested a review December 19, 2024 09:51
@pasha-codefresh pasha-codefresh dismissed their stale review December 19, 2024 09:52

doing changes

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (12a4dab) to head (5c71f50).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21258      +/-   ##
==========================================
+ Coverage   53.34%   55.18%   +1.83%     
==========================================
  Files         337      337              
  Lines       57056    57055       -1     
==========================================
+ Hits        30439    31483    +1044     
+ Misses      23974    22871    -1103     
- Partials     2643     2701      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 force-pushed the testifier branch 2 times, most recently from c65ba9d to e1ba6d4 Compare December 19, 2024 12:38
@mmorel-35 mmorel-35 marked this pull request as ready for review December 19, 2024 12:39
@mmorel-35 mmorel-35 marked this pull request as draft December 19, 2024 16:12
@mmorel-35 mmorel-35 marked this pull request as ready for review December 19, 2024 16:21
@mmorel-35 mmorel-35 force-pushed the testifier branch 2 times, most recently from 81b1d7d to e9f4a2f Compare December 20, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants