-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use testify instead of testing.Fatal #21258
base: master
Are you sure you want to change the base?
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Thank you! This is very important work |
@mmorel-35 could you please check, tests fails due to your changes |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21258 +/- ##
==========================================
+ Coverage 53.34% 55.18% +1.83%
==========================================
Files 337 337
Lines 57056 57055 -1
==========================================
+ Hits 30439 31483 +1044
+ Misses 23974 22871 -1103
- Partials 2643 2701 +58 ☔ View full report in Codecov by Sentry. |
c65ba9d
to
e1ba6d4
Compare
81b1d7d
to
e9f4a2f
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
Description