Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable use-any from revive #21282

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

Description

revive helps ensure a number of rules

use-any proposes to replace instances of interface{} with any.

@mmorel-35 mmorel-35 requested a review from a team as a code owner December 21, 2024 09:02
Copy link

bunnyshell bot commented Dec 21, 2024

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-355lk7.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-355lk7.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 86.94992% with 86 lines in your changes missing coverage. Please review.

Project coverage is 55.20%. Comparing base (12a4dab) to head (61ed376).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiclient/application/forwarder_overwrite.go 31.81% 15 Missing ⚠️
cmd/argocd-dex/commands/argocd_dex.go 0.00% 7 Missing ⚠️
server/application/application.go 63.63% 4 Missing ⚠️
util/clusterauth/clusterauth.go 55.55% 0 Missing and 4 partials ⚠️
util/grpc/errors.go 0.00% 4 Missing ⚠️
util/kustomize/kustomize.go 63.63% 4 Missing ⚠️
util/settings/settings.go 80.00% 4 Missing ⚠️
pkg/apiclient/grpcproxy.go 0.00% 3 Missing ⚠️
server/application/broadcaster.go 0.00% 3 Missing ⚠️
util/errors/errors.go 0.00% 3 Missing ⚠️
... and 24 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21282      +/-   ##
==========================================
+ Coverage   53.34%   55.20%   +1.85%     
==========================================
  Files         337      337              
  Lines       57056    57055       -1     
==========================================
+ Hits        30439    31495    +1056     
+ Misses      23974    22867    -1107     
- Partials     2643     2693      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 force-pushed the golangci-lint/revive/use-any branch from 6454001 to 61ed376 Compare December 21, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant