Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable importas for k8s.io/apimachinery/pkg/apis/meta/v1 #21284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

Description

Importas helps ensure consistency of imports aliases.

This is only for k8s.io/apimachinery/pkg/apis/meta/v1 yet here

@mmorel-35 mmorel-35 requested a review from a team as a code owner December 21, 2024 12:00
Copy link

bunnyshell bot commented Dec 21, 2024

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-bzlyrr.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-bzlyrr.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 44.73684% with 42 lines in your changes missing coverage. Please review.

Project coverage is 55.23%. Comparing base (12a4dab) to head (21f45ce).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/admin/backup.go 0.00% 17 Missing ⚠️
applicationset/utils/selector.go 20.00% 4 Missing ⚠️
cmd/argocd/commands/admin/cluster.go 0.00% 4 Missing ⚠️
cmd/argocd/commands/admin/repo.go 0.00% 3 Missing ⚠️
cmd/argocd/commands/admin/settings.go 50.00% 2 Missing ⚠️
controller/sync.go 60.00% 2 Missing ⚠️
notification_controller/controller/controller.go 60.00% 1 Missing and 1 partial ⚠️
server/cluster/cluster.go 50.00% 2 Missing ⚠️
cmd/argocd/commands/admin/app.go 75.00% 1 Missing ⚠️
cmd/argocd/commands/admin/initial_password.go 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21284      +/-   ##
==========================================
+ Coverage   53.34%   55.23%   +1.88%     
==========================================
  Files         337      337              
  Lines       57056    57055       -1     
==========================================
+ Hits        30439    31515    +1076     
+ Misses      23974    22845    -1129     
- Partials     2643     2695      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant