Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Logs API stops functioning when a pod fails #21287

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Fluder-Paradyne
Copy link
Contributor

@Fluder-Paradyne Fluder-Paradyne commented Dec 21, 2024

Closes: #21286

Checks if a pod has been stopped and if it is, skips creating log stream

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Copy link

bunnyshell bot commented Dec 21, 2024

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-6r5kao.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-6r5kao.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.27%. Comparing base (f15e1bc) to head (d0e06c7).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
server/application/application.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21287      +/-   ##
==========================================
+ Coverage   55.23%   55.27%   +0.04%     
==========================================
  Files         337      337              
  Lines       57055    57063       +8     
==========================================
+ Hits        31515    31544      +29     
+ Misses      22847    22835      -12     
+ Partials     2693     2684       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Fluder-Paradyne <[email protected]>
Signed-off-by: Fluder-Paradyne <[email protected]>
Signed-off-by: Fluder-Paradyne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs API Stops Functioning When a Pod Fails
1 participant