refactor(deps): migrate from deprecated tslint to eslint

[agilgur5]

Motivation

• tslint had been officially deprecated in favor of eslint with @typescript-eslint since at least early 2019
  • it's been completely archived since at least mid-2021 as well
  • this started blocking usage of newer TS features too, such as import type in refactor(ui): code-split gigantic Monaco Editor dep #12150 (comment), build(ui): code-split ApiDocs and Reports components #12061 (export type there), refactor(ui): code-split out large xterm dep #12158, etc

Config is based on argoproj/argo-ui#265 (which I reviewed and which was written by a Prettier maintainer) and double-checked against another tslint -> eslint migration I recently reviewed as well in ezolenko/rollup-plugin-typescript2#463

Modifications

General migration changes

• modify static analysis docs to mention eslint instead of tslint

  • also update note about Snyk to include dependency scans and mention that it's used as an SCA (Software Composition Analysis)

• migrate lint script to use eslint

• migrate all tslint deps, including plugin-react and plugin-prettier

  • NOTE: we have an outdated version of prettier (v1.x, while v3.x is latest), so equivalently had to use an outdated version of eslint-plugin-prettier (v3.x of the plugin, see v4 breaking changes and v5 breaking changes that require prettier v2 and v3, respectively)
    • I imagine this might have been outdated because there was no newer tslint-plugin-prettier that supported newer prettier versions
      • i.e. this very eslint migration was a pre-requisite to upgrade prettier

• migrate tslint.json to .eslintrc.json

  • more or less the same configuration with same plugins
  • use recommended rulesets
  • globally disable @typescript-eslint/no-explicit-any and @typescript-eslint/no-non-null-assertion
    • these are commonly disabled as both of these are already explicit typings (as opposed to implicit ones, which we should check for)
      • there are valid uses of these two, and while they can be misused, that's somewhat uncommon (in my experience)
    • consistent with argo-ui's configuration in chore: migrates from tslint to eslint argo-ui#265

Automatic fixes and changes

• auto-fix <a target='_blank'> elements that were missing a rel='noreferrer', per react/jsx-no-target-blank rule

  • this is a security vuln per the docs
    • see also https://mathiasbynens.github.io/rel-noopener and https://html.spec.whatwg.org/multipage/links.html#link-type-noopener
      • browsers have implicitly added rel='noreferrer' since at least 2021 as well per the above spec change; this (recommended) rule makes it explicitly added

• auto-fix some unnecessary !!, per no-extra-boolean-cast rule

• auto-format webpack.config.js as previously prettier wasn't run on it (not a TS file)

  • manually add some ESLint comments so that it works with Node & CJS
    • may want to migrate to webpack.config.mjs in the future for ESM
      • or webpack.config.ts

Manual fixes and changes

• manually fix several unused variables, per @typescript-eslint/no-unused-vars rule

  • remove unused _, e, x, i, etc
  • remove unused onError prop
  • actually use the previously unused T generic type in object-parser

• manually fix unnecessary <T extends any>, per @typescript-eslint/no-unnecessary-type-constraint rule

  • just use regular <T>, which is the same
  • editor had some trouble understanding the syntax, so while doing so, also converted several consts assigned to anonymous functions to named functions
    • and then had a few more inner changes to named functions while at it too
      • and one promise chain -> async/await refactor while at that as well (partial fix for UI: Refactor to use async/await syntax #11740)

• manually fix two missing keys in React iterators, per react/jsx-key rule

  • React warns when these are missing at run-time as well, see React docs on key

• manually replace several single and double quotes inside of JSX with HTML escaped chars instead, per react/no-unescaped-entities rule

  • use ' and " consistently for these

• manually fix a few require statements, per @typescript-eslint/no-var-requires rule

  • disable in webpack.config.js per above
  • disable in index.tsx as I'm not sure if react-hot-loader can support async imports
    • react-hot-loader is also deprecated in favor of React Fast Refresh and hasn't received an update in at least a year
      • so eventually we should replace it anyway. rather than trying to get it to work with async imports, just add a disable line
  • remove and uninstall superagent-promise as it's not needed nowadays
    • superagent-promise hasn't gotten an update in at least 5 years and superagent has long natively supported promises
      • heck the types used were from superagent itself also
  • convert a few require('*.scss') side-effects into import '*.scss'
    • react-datepicker already had a .css import as well
    • consistently use ESM syntax where possible
    • also, re-group some imports while at it
      • consistently have external imports -> internal imports -> internal side-effects (e.g. CSS)

• manually remove unnecessary \ escape chars, per no-useless-escape rule

• manually remove an unnecessary // @ts-ignore comment, per @typescript-eslint/ban-ts-comment rule

  • it should be replaced with a // @ts-expect-error instead, but this seemed to be unnecessary as there was no error at this time (there may have been in the past?)

• manually remove unused qeId prop, per react/no-unknown-property rule

  • this seems to have been for testing purposes, but it is unused and also outdated
    • current testing paradigms tend to use valid HTML data-* attributes nowadays, such as Testing Library's data-testid

• manually remove a few of the tslint:disable comments

  • no-console, no-bitwise, and prefer-for-of
    • no-console and no-bitwise are not part of ESLint's recommended ruleset at this time, so no need replace with eslint-disable comments
    • prefer-for-of is part of the separated stylistic package of typescript-eslint, which we do not currently use

• also convert a few consts assigned to anonymous functions to named functions for better tracing while refactoring related code

Verification

Tested locally, had no issues. Screenshot of UI working:

It's also primarily build/CI and stylistic changes

[terrytangyuan]

Please resolve conflicts

[agilgur5]

Rebased and resolved conflicts