feat(CLI): support backfill for cron workflow. Part of #2706 #13999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Saravanan Balasubramanian <[email protected]> Co-authored-by: shuangkun <[email protected]> Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
shuangkun
changed the title
tczhao
reviewed
Dec 19, 2024
| Namespace: Namespace, | ||
| LabelRequirements: parse, | ||
| }) | ||
| s.CheckError(err) |
There was a problem hiding this comment.
should we check backfill workflow actually exist, incase this returns empty list
| --format string Date format for Schedule time value (default "Mon, 02 Jan 2006 15:04:05 MST") | ||
| -h, --help help for backfill | ||
| --name string Backfill name | ||
| --parallel Enabled all backfile workflows run parallel |
There was a problem hiding this comment.
Suggested change
| --parallel Enabled all backfile workflows run parallel | |
| --parallel Enabled all backfill workflows run parallel |
| return nil | ||
| } | ||
|
|
||
| var backfillWf = `{ |
There was a problem hiding this comment.
Suggested change
| var backfillWf = `{ | |
| const backfillWf = `{ |
| var scheList []string | ||
| wf := common.ConvertCronWorkflowToWorkflow(cronWF) | ||
| paramArg := `{{inputs.parameters.backfillscheduletime}}` | ||
| wf.GenerateName = cronWF.Name + "-backfill-" + strings.ToLower(cliOps.name) + "-" |
There was a problem hiding this comment.
we may want to truncate this in case this gets too long
| ### Options | ||
|
|
||
| ``` | ||
| --argname string Schedule time argument name for workflow (default "cronScheduleTime") |
There was a problem hiding this comment.
wondering if we really need this, it's only for parent workflow, right?
| ` | ||
|
|
||
| func CreateMonitorWf(ctx context.Context, wf, namespace, cronWFName string, scheTime []string, wfClient workflow.WorkflowServiceClient, cliOps backfillOpts) error { | ||
| const maxWfCount = 1000 |
There was a problem hiding this comment.
need to expose this as an argument?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base #4212
Airflow is easy to backfill. Simplify the use of backfill on Argo.
Support：
Part of #2706
Motivation
Modifications
Verification