Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print warnings returned from pipeline start request #210

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

danielpeach
Copy link
Contributor

Description

Motivation and Context

How has this been tested? How can a reviewer test these changes?

Have your performed the following tests?

Please confirm you have done the following tests to ensure your pull request is ready to be merged..

  • If this change modifies the deployment flow have triggered a deployment using this branch (i.e. build/bin/darwin_amd64/armory deploy start -f <path to file>)?
  • If this change modifes the login flow have you tried logging in and out with this branch (i.e. build/bin/darwin_amd64/armory login) and verified the credentials work?
  • Have you verified the specific change made in this PR?

go.mod Outdated
sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect
sigs.k8s.io/yaml v1.3.0 // indirect
)

replace github.com/armory-io/deploy-engine => ../deploy-engine
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for deploy-engine release

Copy link
Contributor

@aelath aelath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Provisional approval for when you use the deploy-engine release.

@armory-cloud-sonarqube
Copy link

@danielpeach danielpeach merged commit ba88b7f into main Nov 30, 2023
4 checks passed
@danielpeach danielpeach deleted the dp/CDAAS-1971 branch November 30, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants