Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowing arquillian container to wait for sometime #38

Closed
wants to merge 3 commits into from

Conversation

ankathur
Copy link
Contributor

@ankathur ankathur commented Jun 1, 2017

It seems arquillian conatiner is looking for glassfish even before glassfish has started properly.
So adding some wait time to resolve the issue.

Fixes #37

@bartoszmajsak
Copy link
Member

Thank you very much for your pull request. I would like to suggest following improvements:

  • let's make timeout set by default to 5s but configurable through arquillian.xml see configuration class for details
  • we can also define polling to detect availability of the server even faster. This again can be for example fixed to 100ms and configurable through arquillian.xml.

Both of configurable values can be miliseconds for the time being.

This way we can fine tune waiting time and do not wait unnecessarily long during test execution.

@ankathur
Copy link
Contributor Author

ankathur commented Jun 1, 2017

Thanks for your input. I do feel this should be configurable. I will update the pull request.

@ankathur
Copy link
Contributor Author

ankathur commented Jun 27, 2017

Please review the updated PR for #37

@jjsnyder
Copy link

jjsnyder commented Jul 6, 2017

@bartoszmajsak, Can you merge @ankathur's changes if you approve of them? We would like to setup nightly runs of the tck and are waiting for the changes to be public.
JJ

@bartoszmajsak
Copy link
Member

Sure, I fixed two minor things

  • Code formatting
  • Renamed properties
    • waitTime -> waitTimeMs
    • polling -> retries

@bartoszmajsak
Copy link
Member

Pushed upstream 389a4d9

Thanks for your contribution.

@bartoszmajsak
Copy link
Member

bartoszmajsak commented Jul 6, 2017

New version has been released. It will take a bit to land it in central, but normally less than a day. Please note that we are gradually switching to widely known semantic versioning scheme - which essentially means we are dropping .Final suffix (we were semantic before too, but we decided to follow well-known convention)

New version is 1.0.1.

@jjsnyder
Copy link

jjsnyder commented Jul 6, 2017

Ok, I'll keep an eye out for it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDI TCK test(testSessionContextActiveOnStartAsync) is failing.
3 participants