-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allowing arquillian container to wait for sometime #38
Conversation
Thank you very much for your pull request. I would like to suggest following improvements:
Both of configurable values can be miliseconds for the time being. This way we can fine tune waiting time and do not wait unnecessarily long during test execution. |
Thanks for your input. I do feel this should be configurable. I will update the pull request. |
Please review the updated PR for #37 |
@bartoszmajsak, Can you merge @ankathur's changes if you approve of them? We would like to setup nightly runs of the tck and are waiting for the changes to be public. |
Sure, I fixed two minor things
|
Pushed upstream 389a4d9 Thanks for your contribution. |
New version has been released. It will take a bit to land it in central, but normally less than a day. Please note that we are gradually switching to widely known semantic versioning scheme - which essentially means we are dropping New version is |
Ok, I'll keep an eye out for it. Thank you! |
It seems arquillian conatiner is looking for glassfish even before glassfish has started properly.
So adding some wait time to resolve the issue.
Fixes #37