Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update suspendapp-ktor to support ktor 3 and arrow 2 #135

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

tKe
Copy link

@tKe tKe commented Oct 14, 2024

No description provided.

tKe added 2 commits October 14, 2024 16:13
⚠️ will no longer be compatible with ktor2
@tKe
Copy link
Author

tKe commented Oct 14, 2024

The downside of this approach is that subsequent releases of SuspendApp, such as to support arrow-2, will not support ktor2, unless a maintenance branch is created.

An alternative would be to create a separate suspendapp-ktor3 module and continue to support ktor2 in the suspendapp-ktor module (potentially with a rename and maven redirect to suspendapp-ktor2. This may also require moving the ktor dependency version from the common /gradle/libs.versions.toml into each module to allow renovate to better manage the versions.

@tKe tKe changed the title Update suspendapp-ktor to support ktor 3 Update suspendapp-ktor to support ktor 3 and arrow 2 Nov 27, 2024
@serras serras self-requested a review December 8, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant