Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump GHA action plugins to avoid deprecation warnings #689

Merged
merged 2 commits into from
May 28, 2024

Conversation

zenspider
Copy link
Contributor

simple bump, removes old node warnings

@ylecuyer
Copy link
Collaborator

ylecuyer commented May 1, 2024

Could you show an example of the deprecation warning and where you see them, I can't find them in the CI logs

@ylecuyer
Copy link
Collaborator

ylecuyer commented May 1, 2024

Commented to fast, I found them here: https://github.com/arsduo/koala/actions/runs/8916001798

Screenshot_2024-05-02_01-19-43

@ylecuyer
Copy link
Collaborator

ylecuyer commented May 1, 2024

Could you also bump paambaati/codeclimate-action to v6, this way we can clear all deprecation warning at once. I tried to update the PR directly but looks like it is forbiden by the org, or the allow maintainer to edit option on the PR isn't enabled

@zenspider
Copy link
Contributor Author

done!

sorry I missed that one... we yanked codeclimate from our fork because we're forbidden from using that action.

@zenspider zenspider changed the title Bump actions/checkout to v4 to avoid deprecation warnings Bump GHA action plugins to avoid deprecation warnings May 2, 2024
@ylecuyer
Copy link
Collaborator

ylecuyer commented May 5, 2024

Could you add this to the changelog please as the PR is still not editable by maintainers I can't do it:

diff --git a/changelog.md b/changelog.md
index 8a22e01..1868d01 100644
--- a/changelog.md
+++ b/changelog.md
@@ -19,6 +19,7 @@ Testing improvements:
 
 * Fix CI for ruby 3.4 ([#688](https://github.com/arsduo/koala/pull/688))
 * Add latest rubies to CI ([#687](https://github.com/arsduo/koala/pull/687))
+* Bump GHA action plugins to avoid deprecation warnings ([#689](https://github.com/arsduo/koala/pull/689))
 
 Others

@zenspider zenspider force-pushed the zenspider/update_actions branch from 198d8c4 to 1cf6e59 Compare May 6, 2024 21:04
@zenspider
Copy link
Contributor Author

pushed with requested edits

@ylecuyer ylecuyer merged commit b4990f5 into arsduo:master May 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants