Dark Mode not working

[MariusSp]

The Dark mode is not working for me even though I have selected it in Firefox settings.

Galaxy Tab S8 with Mull.

[artisticfox8]

The Dark mode is not working for me even though I have selected it in Firefox settings.

Galaxy Tab S8 with Mull.

Is your system theme set to dark?

[MariusSp]

Yes

[artisticfox8]

Yes

System theme, not Firefox theme

[artisticfox8]

The dark mode is just a simple
@media (prefers-color-scheme: dark) in CSS

[artisticfox8]

Also, which addons are you running?

[artisticfox8]

Dark Reader may sometimes interfere

[MariusSp]

Yes

System theme, not Firefox theme
Both system and firefox themes are dark.

Running Ublock Origin and DarkReader, although I disabled the latter for the time being.

[artisticfox8]

Well, I implemented the dark mode the simplest possible way, so there may be a bug in the fork of Firefox you're using

[artisticfox8]

What Android version are you on?

[MariusSp]

Latest Android 13 for the Galaxy Tab S8
Mull also latest Version from Fdroid.

[artisticfox8]

Latest Android 13 for the Galaxy Tab S8 Mull also latest Version from Fdroid.

I'm also on a Samsung device, but it works for me.
Have you tried using the official Firefox build from Mozilla?

[panbroggi]

Hi, same issue with same configuration of Mull. Do you think it may be possible to add a dark mode switch in the extension setting?
P.s. thank you for the extension!

[artisticfox8]

Hi, same issue with same configuration of Mull. Do you think it may be possible to add a dark mode switch in the extension setting? P.s. thank you for the extension!

I think the issue is caused by an about:config setting in Mull which, aiming to increase privacy, hides the true value of prefers-color-scheme media query to websites. Since the addon is running inside of an iframe, on a website, it is impacted by this too.

The reason why I didn't ship a JS powered dark mode was to avoid flashes of white before settings are received by the tab bar iframe, and the proper color would be set.

So I could implement a dark mode, but if I send settings to a tab from a background script (where they are loaded in RAM), it is still slow enough for the user to notice. So if you have any hack/idea how to retrieve that dark mode setting faster, that would be nice

[artisticfox8]

The Manifest V3 session storage API looks promising (as its all in memory, can be done as shared memory, so it should be fast), but then I'd have to rewrite the entire thing to Manifest V3, which would probably add random slowness since background scripts are not allowed to be persistent in MV3, meaning once the background script is forcibly turned off, the user would send an event from the tab bar, which would wake up (start) the background script, which would then execute what's needed. It would basically have to be loaded from the disk, compared to being loaded in memory all the time right now (MV2)

[artisticfox8]

Perhaps an interesting quick fix for you is considering Dark Reader. Apart from giving all websites a nice color scheme, it also gives the tab bar a dark mode (even when the tab bar is set to light mode by Android's theme setring.), solving the situation.