Fix sub-pixel rounding errors on % width fotoramas #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no advantage to GPU-accelerating the stage, as this element isn't animating. Does this removes the subpixel rounding errors which will happen on percentage width GPU-accelerated elements on Chrome & Firefox.
|
If you want to test that this doesn't affect anything, the easiest way is to turn on paint flashing in the Chrome DevTools and animate a fotorama with the translateZ property turned on and off - the amount of repainting is the same either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no advantage to GPU-accelerating the stage, as this element isn't animating.
Does this removes the subpixel rounding errors which will happen on percentage width GPU-accelerated elements on Chrome & Firefox.