Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update helpers.js #124

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update helpers.js #124

wants to merge 2 commits into from

Conversation

arkdev1
Copy link

@arkdev1 arkdev1 commented Mar 7, 2024

Summary

I updated helpers.js to fix a recurring problem, eval() returned a JS error:

Uncaught SyntaxError: Unexpected end of input
    at app-08a4b5f5.js:738:14381
    at Array.reduce (<anonymous>)
    at mergedOptionsWithJsonConfig (app-08a4b5f5.js:738:14178)
    at Proxy.drawChart (app-08a4b5f5.js:738:21078)
    at app-08a4b5f5.js:738:19964

eval() with vite has "security" risk?
resources/js/vendor/livewire-charts/helpers.js (20:58) Use of eval in "resources/js/vendor/livewire-charts/helpers.js" is strongly discouraged as it poses security risks and may cause issues with minification.

Issue

No issue

Type of Change

  • 🚀 New Feature
  • 🐛 Bug Fix
  • 🔨 Refactor
  • ❓ [Other]

Screenshot/Video

image

arkdev1 added 2 commits March 7, 2024 10:24
@arkdev1
Update helpers.js
5e54f9d 
Remove eval() from helpers.js - Trying to resolve "Unexpected end of input"
@arkdev1
Update helpers.js
1850504 
Remove console.log()
@arkdev1 arkdev1 requested a review from asantibanez as a code owner March 7, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asantibanez asantibanez Awaiting requested review from asantibanez asantibanez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arkdev1