Skip to content

Commit

Permalink
Apply monitoringlinter
Browse files Browse the repository at this point in the history
Apply monitoringlinter, which is designed to enforce
kubevirt/community#219 by ensuring that monitoring-related practices are
implemented within the pkg/monitoring directory using
operator-observability methods.

Signed-off-by: assafad <[email protected]>
  • Loading branch information
assafad committed Mar 17, 2024
1 parent 827633e commit 04eef45
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
6 changes: 5 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,9 @@ generate-doc:
lint-metrics:
./hack/prom_metric_linter.sh --operator-name="kubevirt" --sub-operator-name="cnao"

lint-monitoring:
go install github.com/kubevirt/monitoring/monitoringlinter/cmd/monitoringlinter@e2be790
monitoringlinter ./...

.PHONY: \
$(E2E_SUITES) \
Expand Down Expand Up @@ -248,5 +251,6 @@ lint-metrics:
prom-rules-verify \
release \
update-workflows-branches \
statify-components
statify-components \
lint-monitoring

1 change: 1 addition & 0 deletions automation/check-patch.unit-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ main() {
make check
verify_metrics_docs_updated
make lint-metrics
make lint-monitoring
make docker-build
}

Expand Down

0 comments on commit 04eef45

Please sign in to comment.