Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add abbreviation replacement data augmentation op and test #732

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/code/data_aug.rst
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,11 @@ Data Augmentation Ops
.. autoclass:: forte.processors.data_augment.algorithms.eda_ops.RandomDeletionDataAugmentOp
:members:

:hidden:`AbbreviationReplacementOp`
------------------------------------------
.. autoclass:: forte.processors.data_augment.algorithms.abbreviation_replacement_op.AbbreviationReplacementOp
:members:

Data Augmentation Models
========================================

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
# Copyright 2022 The Forte Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.


import random
import json
from typing import Tuple, Dict, Any

import requests
from forte.data.ontology import Annotation
from forte.processors.data_augment.algorithms.single_annotation_op import (
SingleAnnotationAugmentOp,
)
from forte.common.configuration import Config

__all__ = [
"AbbreviationReplacementOp",
]


class AbbreviationReplacementOp(SingleAnnotationAugmentOp):
r"""
This class is a replacement op utilizing a pre-defined
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring should be more comprehensive. This is what the user is going to see if they want to use this DA op.

abbreviation dictionary to replace word or phrase
with an abbreviation. The abbreviation dictionary can
be user-defined, we also provide a default dictionary.
`prob` indicates the probability of replacement.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "probability of replacement" mean? For example, if prob is 0.4, is the replacement happen 40% of the case or the other way around. Does it mean that 40% of the words will be replaced, etc. Let's specify this clearly.

"""

def __init__(self, configs: Config):
super().__init__(configs)

dict_path = configs["dict_path"]

try:
r = requests.get(dict_path)
self.data = r.json()
except requests.exceptions.RequestException:
with open(dict_path, encoding="utf8") as json_file:
self.data = json.load(json_file)

def single_annotation_augment(
self, input_anno: Annotation
) -> Tuple[bool, str]:
r"""
This function replaces a phrase from an abbreviation dictionary
with `prob` as the probability of replacement.
If the input phrase does not have a corresponding phrase in the
dictionary, no replacement will happen, return False.

Args:
input_anno: The input annotation, could be a word or phrase.

Returns:
A tuple, where the first element is a boolean value indicating
whether the replacement happens, and the second element is the
replaced string.

"""
# If the replacement does not happen, return False.
if random.random() > self.configs.prob:
return False, input_anno.text
if input_anno.text in self.data.keys():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are returning from the function if the program enters the earlier if statement, you dont need to add this if

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I am not sure is this check (input_anno.text in self.data.keys()) is necessary.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking if the input phrase does not have a corresponding abbreviation, an error will occur.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When checking dict existence, use text in self.data, don't need to call the keys().
  2. Now we can see that the prob only applies to the annotation that has an abbreviation, which should probably be specified in the class docstring.

result: str = self.data[input_anno.text]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something about this replacement:

  1. Do we need to consider the case? Maybe we should lower case your dictionary and user input.
  2. How about substrings? For example, in "see you later": "syl8r", what if we have an input "i will see you later", it looks like we won't replace this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you need to consider using an Aho-Corasick data sturcture here: https://pyahocorasick.readthedocs.io/en/latest/

return True, result
else:
return False, input_anno.text

@classmethod
def default_configs(cls) -> Dict[str, Any]:
r"""
Returns:
A dictionary with the default config for this processor.
Following are the keys for this dictionary:

- prob: The probability of replacement,
should fall in [0, 1]. Default value is 0.5.

- dict_path: the `url` or the path to the pre-defined
abbreviation json file. The key is a word / phrase we want
to replace. The value is an abbreviated word of the
corresponding key. Default dictionary is from a web-scraped
slang dictionary
("https://github.com/abbeyyyy/JsonFiles/blob/main/abbreviate.json").
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we adopt the dictionary from another library?


"""
return {
"augment_entry": "ft.onto.base_ontology.Phrase",
"other_entry_policy": {
"ft.onto.base_ontology.Phrase": "auto_align",
},
"dict_path": "https://raw.githubusercontent.com/abbeyyyy/"
"JsonFiles/main/abbreviate.json",
"prob": 0.5,
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
# Copyright 2022 The Forte Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""
Unit tests for dictionary word replacement op.
"""

import unittest
from forte.data.data_pack import DataPack
from ft.onto.base_ontology import Phrase
from forte.processors.data_augment.algorithms.abbreviation_replacement_op import (
AbbreviationReplacementOp,
)


class TestAbbreviationReplacementOp(unittest.TestCase):
def setUp(self):
self.abre = AbbreviationReplacementOp(
configs={
"dict_path": "https://raw.githubusercontent.com/abbeyyyy/"
"JsonFiles/main/abbreviate.json",
"prob": 1.0,
}
)

def test_replace(self):
data_pack_1 = DataPack()
text_1 = "I will see you later!"
data_pack_1.set_text(text_1)
phrase_1 = Phrase(data_pack_1, 7, len(text_1) - 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you have to first identify the phrase before doing the match, which is not a very typical use case.

data_pack_1.add_entry(phrase_1)

augmented_data_pack_1 = self.abre.perform_augmentation(data_pack_1)
augmented_phrase_1 = list(
augmented_data_pack_1.get("ft.onto.base_ontology.Phrase")
)[0]

self.assertIn(
augmented_phrase_1.text,
["syl8r", "cul83r", "cul8r"],
)

# Empty phrase
data_pack_2 = DataPack()
data_pack_2.set_text(text_1)
phrase_2 = Phrase(data_pack_2, 0, 0)
data_pack_2.add_entry(phrase_2)

augmented_data_pack_2 = self.abre.perform_augmentation(data_pack_2)
augmented_phrase_2 = list(
augmented_data_pack_2.get("ft.onto.base_ontology.Phrase")
)[0]

self.assertIn(
augmented_phrase_2.text,
[""],
)

# no abbreviation exist
data_pack_3 = DataPack()
data_pack_3.set_text(text_1)
phrase_3 = Phrase(data_pack_3, 2, 6)
data_pack_3.add_entry(phrase_3)

augmented_data_pack_3 = self.abre.perform_augmentation(data_pack_3)
augmented_phrase_3 = list(
augmented_data_pack_3.get("ft.onto.base_ontology.Phrase")
)[0]

self.assertIn(
augmented_phrase_3.text,
["will"],
)

if __name__ == "__main__":
unittest.main()