Update dataset_utils_test.py #301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tanyuqian mind take a quick look of this? |
tanyuqian
reviewed
Aug 29, 2021
There was a problem hiding this comment.
This update is correct. Thanks for the contribution! @DLPerf
However I found this doesn't change the running time a lot cuz the file is just a tiny-scale unit test. (~0.2s in my machine before and after the change) Do you know any other places in Texar that need this update?
Anyways I'll vote to approve it:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,this issue shows the reason that I commit this PR.
I sincerely wish my PR will help you.And if you think my PR has a little work,Hoping you could merge it.
Thank you,my friend.