feat(kafka): add AVRO type in message key binding #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M3lkior
force-pushed
the
feat/add-avro-to-kafka-bindings-key
branch
from
418d7d4 to
ed839e2
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
fmvilas
reviewed
Sep 13, 2021
M3lkior
force-pushed
the
feat/add-avro-to-kafka-bindings-key
branch
from
106af09 to
d4218b4
Compare
Co-authored-by: Fran Méndez <[email protected]>
M3lkior
force-pushed
the
feat/add-avro-to-kafka-bindings-key
branch
from
d4218b4 to
8b4e853
Compare
magicmatatjahu
approved these changes
Sep 14, 2021
yes, but it allows to fix the regression from the nunjunks template to the react refactoring :) |
|
@M3lkior Sorry 😅 What do you mean by:
? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to asyncapi/avro-schema-parser#67
Here is the related update due to the support of avro file in kafka key bindings