-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include a map section on each venue page #174
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Looks good! Just a minor suggestion: can you reduce the height of the map a bit? |
@AceTheCreator what suggestion would you have the ideal height to be? |
I mean probably half of the current height we have now @kabszac |
@AceTheCreator thank you let me make the necessary changes |
@kabszac any update on this? |
@AceTheCreator made the changes |
@kabszac you have a merge conflict :) |
@AceTheCreator resolved the merge conflict |
@kabszac, I am so sorry about the late review. Can you kindly resolve the following conflict one lat time? |
@AceTheCreator resolved |
I keep getting the following error when previewing the page. 🤔 |
@AceTheCreator let me try opening another pull request on this issue. is it ok? |
Okay 👍🏾 |
Description