-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stop carousel from scrolling with few events (#397) #405
fix: stop carousel from scrolling with few events (#397) #405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toffee-k21 based on the preview of this PR, the venues should be centered https://deploy-preview-405--peaceful-ramanujan-288045.netlify.app/
@AceTheCreator I have fixed the issue you mentioned, thanks for giving me the feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the logic inside this component inside https://github.com/asyncapi/conference-website/blob/a9b9f545baca84dee03b8dc9bb55f7ce2a6be1f6/components/Slider/slider.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toffee-k21 one more thing, make the venue images .webp
@AceTheCreator .gif when converted to .webp will be static, are you sure to make this change ? |
Hey @toffee-k21 the |
@AceTheCreator @ashmit-coder Is it fine now? |
@toffee-k21 some of the checks are failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
/rtm |
Description
Fixed issue #397
Stopped the carousel from scrolling with a few events