Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop carousel from scrolling with few events (#397) #405

Merged
merged 13 commits into from
Oct 16, 2024

Conversation

toffee-k21
Copy link
Contributor

Description
Fixed issue #397
Stopped the carousel from scrolling with a few events

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 860dfbb
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/670fadff67e3f0000852ab32
😎 Deploy Preview https://deploy-preview-405--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toffee-k21 based on the preview of this PR, the venues should be centered https://deploy-preview-405--peaceful-ramanujan-288045.netlify.app/
AsyncAPI-Conference-10-07-2024_07_39_PM

@toffee-k21
Copy link
Contributor Author

@AceTheCreator I have fixed the issue you mentioned, thanks for giving me the feedback

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

components/Header/header.js Outdated Show resolved Hide resolved
Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toffee-k21 one more thing, make the venue images .webp

@toffee-k21
Copy link
Contributor Author

@toffee-k21 one more thing, make the venue images .webp

@AceTheCreator .gif when converted to .webp will be static, are you sure to make this change ?

@ashmit-coder
Copy link
Collaborator

@toffee-k21 one more thing, make the venue images .webp

@AceTheCreator .gif when converted to .webp will be static, are you sure to make this change ?

Hey @toffee-k21 the online edition image in jpeg format just convert it to .webp and leave the rest to GIFs

@toffee-k21
Copy link
Contributor Author

@AceTheCreator @ashmit-coder Is it fine now?

@AceTheCreator
Copy link
Member

@toffee-k21 some of the checks are failing

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@AceTheCreator
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit b5e6e0f into asyncapi:master Oct 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants