Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sticky hamburger menu for mobile version #460

Merged
merged 8 commits into from
Dec 17, 2024

Conversation

r3yc0n1c
Copy link
Contributor

Description

  • Fixed top position of the hamburger menu, keeping the UI intact
  • Improves the overall UX, users will be able to navigate seamlessly without needing to scroll back up

Related issue(s)
Resolves #455

Demo
Animation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit b645d53
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/6761286d02c96000085ddcb6
😎 Deploy Preview https://deploy-preview-460--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thulieblack
Copy link
Member

Someone else is working on this PR #458

@r3yc0n1c
Copy link
Contributor Author

Someone else is working on this PR #458

I was working on this before them... ref: here

@thulieblack
Copy link
Member

sorry my bad please continue

@catosaurusrex2003
Copy link
Contributor

Instead of making the navbar transparent, could we consider using a blur effect so that the content scrolling behind the navbar is not visible?

@ashmit-coder
Copy link
Collaborator

Instead of making the navbar transparent, could we consider using a blur effect so that the content scrolling behind the navbar is not visible?

@Mayaleeeee would have to approve this.

@ashmit-coder
Copy link
Collaborator

Instead of making the navbar transparent, could we consider using a blur effect so that the content scrolling behind the navbar is not visible?

that would sure look better @r3yc0n1c , thanks for the suggestion @catosaurusrex2003

@r3yc0n1c
Copy link
Contributor Author

Instead of making the navbar transparent, could we consider using a blur effect so that the content scrolling behind the navbar is not visible?

that would sure look better @r3yc0n1c , thanks for the suggestion @catosaurusrex2003

sure! working on in... will send a PR soon

Copy link
Member

@Mayaleeeee Mayaleeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @catosaurusrex2003

Yeah, I love the idea of a transparent nav bar @ashmit-coder

It would work better than the current one in the demo.

I like the current colour on the 2023 conference website

Screenshot_20241112_154520_Chrome.jpg

Screenshot_20241112_154702_Chrome.jpg

@r3yc0n1c
Copy link
Contributor Author

update:

  • Blurred Navbar

Screenshot 2024-11-12 203816
Screenshot 2024-11-12 203834
Screenshot 2024-11-12 204044

@r3yc0n1c r3yc0n1c requested a review from Mayaleeeee November 12, 2024 15:31
@catosaurusrex2003
Copy link
Contributor

image
the navbar blur is looking good 🚀

Should we also convert the solid purple color of hamburger dropdown to a translucent blur just like the navbar?

like taking inspiration of navbar dropdown in mobile viewport from here https://datahack.djss4ds.in/
Pay attention to how the background of the dropdown is translucent and blurred and center alligned.

@Mayaleeeee @ashmit-coder

@AceTheCreator
Copy link
Member

@r3yc0n1c do you plan on adding the suggested changes by @catosaurusrex2003 in the comment above?

@r3yc0n1c
Copy link
Contributor Author

r3yc0n1c commented Nov 15, 2024

@r3yc0n1c do you plan on adding the suggested changes by @catosaurusrex2003 in the comment above?

yeah sure! it looks good actually... shall I get started with the blurred menu items?

@Mayaleeeee
Copy link
Member

image
the navbar blur is looking good 🚀

Should we also convert the solid purple color of hamburger dropdown to a translucent blur just like the navbar?

like taking inspiration of navbar dropdown in mobile viewport from here https://datahack.djss4ds.in/
Pay attention to how the background of the dropdown is translucent and blurred and center alligned.

@Mayaleeeee @ashmit-coder

What solid purple colour?

@r3yc0n1c
Copy link
Contributor Author

image
the navbar blur is looking good 🚀
Should we also convert the solid purple color of hamburger dropdown to a translucent blur just like the navbar?
like taking inspiration of navbar dropdown in mobile viewport from here https://datahack.djss4ds.in/
Pay attention to how the background of the dropdown is translucent and blurred and center alligned.
@Mayaleeeee @ashmit-coder

What solid purple colour?

I think he's referring to the dark purple background (#1B1130) we use in the navbar:

image

@catosaurusrex2003
Copy link
Contributor

I think he's referring to the dark purple background (#1B1130) we use in the navbar:

yes, i am referring to that.

Its just a suggestion

@r3yc0n1c you can give it a try.
@Mayaleeeee once it's done, we can choose the one that looks better.

@r3yc0n1c
Copy link
Contributor Author

I think he's referring to the dark purple background (#1B1130) we use in the navbar:

yes, i am referring to that.

Its just a suggestion

@r3yc0n1c you can give it a try.

@Mayaleeeee once it's done, we can choose the one that looks better.

sure! WIP

@r3yc0n1c
Copy link
Contributor Author

here's the new update:

Animation

@catosaurusrex2003
Copy link
Contributor

catosaurusrex2003 commented Nov 25, 2024

@r3yc0n1c this is looking cool! 🔥

I did notice a small discrepancy between browsers tho

in FIREFOX 👇

The backdrop-blur-md effect works as expected for the dropdown.
image

in CHROME 👇

The blur effect doesn’t work for the dropdown.
image

This might be outside the scope of this PR, but I thought I’d flag it just in case! Apart from this minor issue, it’s looking great to me.

@ashmit-coder @AceTheCreator @Mayaleeeee what do yall think ?

@r3yc0n1c
Copy link
Contributor Author

@r3yc0n1c this is looking cool! 🔥

I did notice a small discrepancy between browsers tho

in FIREFOX 👇

The backdrop-blur-md effect works as expected for the dropdown.

image

in CHROME 👇

The blur effect doesn’t work for the dropdown.

image

This might be outside the scope of this PR, but I thought I’d flag it just in case! Apart from this minor issue, it’s looking great to me.

@ashmit-coder @AceTheCreator @Mayaleeeee what do yall think ?

thank you! the backdrop-blur issue is due to chrome which doesn't seem to allow nested backdrops for tailwind (ref: tailwindlabs/tailwindcss#15103)... that's why I kept the opacity as 90 to compensate this

@catosaurusrex2003
Copy link
Contributor

ok 👍, then lets skip that for now.

Copy link
Collaborator

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashmit-coder
Copy link
Collaborator

/ptal

@asyncapi-bot
Copy link
Contributor

@AceTheCreator @thulieblack Please take a look at this PR. Thanks! 👋

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AceTheCreator
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 9f62974 into asyncapi:master Dec 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Make hamburger menu sticky
7 participants