feat: add conference recordings to Online venue #472
Conversation
Manancode
requested review from
AceTheCreator,
thulieblack,
Mayaleeeee and
ashmit-coder
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/ptal |
|
@AceTheCreator @thulieblack @ashmit-coder @Mayaleeeee Please take a look at this PR. Thanks! 👋 |
There was a problem hiding this comment.
I like the idea, it's will be very easy for anyone looking for the recordings to view and play them directly on the website.
However, I would suggest that the 'More Videos' should show the other recordings (with the name of the presenter or their talks) instead of cards showing 'AsyncAPI Conf on Tour'24).
|
More videos is a feature from YouTube @Mayaleeeee. The playlist is embedded correctly from my perspective |
LGTM as well @Mayaleeeee . |
Ahh, I see. The pr looks good then. |
|
Merging! |
Added conference recording playlist configuration to the Online venue to make sessions easily accessible to attendees directly from the venue page
Added recordings and playlist URLs to Online venue configuration in city-lists.json
Before:
After:
fixes issue