Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: venue card layout and event status #489

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

r3yc0n1c
Copy link
Contributor

@r3yc0n1c r3yc0n1c commented Dec 1, 2024

Description

  • Fixed the Venue cards layout and the event status
  • Responsive layout

Related issue(s)
Resolves #488

Demo

Before

image

After

image

Copy link

netlify bot commented Dec 1, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit a34269d
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/674d7a34e547960008812400
😎 Deploy Preview https://deploy-preview-489--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@r3yc0n1c
Copy link
Contributor Author

r3yc0n1c commented Dec 1, 2024

I had to update the date format for resolving this issue but it seems like someone has already fixed the date format in the json file in #483 ... I think this PR can be merged after that one.

Thank you!

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cc @ashmit-coder

@ashmit-coder
Copy link
Collaborator

/rtm

@asyncapi-bot asyncapi-bot merged commit 64ae8f0 into asyncapi:master Dec 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Inconsistent spacing in the card element in the Venue section on mobile view
4 participants