-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: introduce monorepo to Generator Repo #1213
Conversation
@asyncapi/bounty_team |
@derberg please check added the required lint change. |
let me check though i have fixed these in the local. |
@ayushnau I see linter complains on files from so basically make sure that eslint ignores |
I see it is there already in |
@derberg I have already pushed the changes for eslintignore can you check. |
to fix https://github.com/asyncapi/generator/actions/runs/9211948474/job/25347170425?pr=1213 you need to update https://github.com/asyncapi/generator/blob/master/.github/workflows/pr-testing-with-test-project.yml#L21 probably to |
sure will do this. |
Quality Gate passedIssues Measures |
@derberg please check updated and added the required chagnes for the release. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are ready to go.
generator is still the same as it was before this PR, it is just in a different directory.
tests are passing!
.releaserc is properly updated, so semantic-release npm plugin should know what to do - in theory 😄
I change PR title to refactor
as we do not really have to make a test now to check if new semantic-release config works as anyway next PR will introduce changelog instead of semantic-release. Other PRs that are now in progress will have to adjust to new master
and they will be guinea pigs for release pipeline
/rtm |
Changes Added.
Related issue(s)
Resolves #1044