Removed detail from NiceEventMissionCondition. Use details instead

atlasacademy · Apr 26, 2024 · a293abc · a293abc
1 parent b8ac2b7
commit a293abc
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - `SHORTEN_SKILL` and `EXTEND_SKILL` function uses `Rate`/`Value`/`Value2` dataval instead of `Rate`/`Value`/`Target`
 - Removed `commonConsume` from `NiceEventTreasureBox` and `NiceEventDiggingBlock`. Use `consumes` instead.
 - Removed `commonRelease` from `NiceEventCooltimeReward`. Use `releaseConditions` instead.
+- Removed `detail` from `NiceEventMissionCondition`. Use `details` instead.
 
 ## 5.78.0 - 2022-04-23
 ### Added

diff --git a/app/core/nice/event/mission.py b/app/core/nice/event/mission.py
@@ -68,10 +68,6 @@ def get_nice_mission_cond(
     )
 
     if cond.condType == CondType.MISSION_CONDITION_DETAIL and cond.targetIds:
-        if cond.targetIds[0] in details:
-            nice_mission_cond.detail = get_nice_mission_cond_detail(
-                details[cond.targetIds[0]]
-            )
         nice_mission_cond.details = [
             get_nice_mission_cond_detail(details[detail_id])
             for detail_id in cond.targetIds

diff --git a/app/schemas/nice.py b/app/schemas/nice.py
@@ -1775,7 +1775,6 @@ class NiceEventMissionCondition(BaseModelORJson):
     conditionMessage: str
     closedMessage: str
     flag: int
-    detail: Optional[NiceEventMissionConditionDetail] = None
     details: list[NiceEventMissionConditionDetail] | None = None