Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#187419126 A seller should be able to update & delete a product item from their collection #14

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

Heisjabo
Copy link
Collaborator

@Heisjabo Heisjabo commented Jun 27, 2024

What does this PR do?

This PR Adds product update and deletion of products by sellers

Description of Task to be completed?

  • A seller should be able to view a collection of their products
  • When a seller clicks on edit button on a product they should be redirected to a form with the product information where they can edit and save changes
  • When a seller clicks on delete icon of a product they should be asked for confirmation to delete or cancel the action
  • Test the feature

How should this be manually tested?

  1. Clone the repository.
  2. Checkout to the branch ft-product-update-delete.
  3. Run npm install to install dependencies.
  4. Run npm run dev to start the development server and login as a seller
  5. navigate to /dashboard/products
  6. Test if everything is working as expected

What are the relevant pivotal tracker stories?

Delivers #187419126

Screenshots

Design

Screenshot 2024-07-02 at 5 49 02 PM

Implementation

Screenshot 2024-07-02 at 5 45 32 PM Screenshot 2024-07-02 at 5 45 41 PM Screenshot 2024-07-02 at 5 45 56 PM

Copy link

vercel bot commented Jun 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eagles-ec-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2024 3:17pm

}`}
>
{checked ? (
<svg
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

/>
</svg>
) : (
<svg
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@Heisjabo Heisjabo added the In progress a work in progress label Jun 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 52 lines in your changes missing coverage. Please review.

Project coverage is 75.92%. Comparing base (548eca2) to head (73d3859).

Files Patch % Lines
src/dashboard/sellers/AddProduct.tsx 28.84% 37 Missing ⚠️
src/redux/reducers/productsSlice.ts 65.51% 10 Missing ⚠️
src/components/dashboard/FileUpload.tsx 72.72% 3 Missing ⚠️
src/components/dashboard/CustomSelect.tsx 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #14      +/-   ##
==========================================
- Coverage   78.86%   75.92%   -2.95%     
==========================================
  Files          56       57       +1     
  Lines         899      976      +77     
  Branches       96      107      +11     
==========================================
+ Hits          709      741      +32     
- Misses        186      233      +47     
+ Partials        4        2       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@yvanddniyo yvanddniyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@MugemaneBertin2001 MugemaneBertin2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- a seller should be able to update a product from their collection
- a seller should be able to delete a product from their collection

Delivers #187419126
@Heisjabo Heisjabo force-pushed the ft-product-update-delete branch from 21d101c to 73d3859 Compare July 6, 2024 15:16
Copy link

codeclimate bot commented Jul 6, 2024

Code Climate has analyzed commit 73d3859 and detected 0 issues on this pull request.

View more on Code Climate.

@teerenzo teerenzo merged commit ea6be3d into dev Jul 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants