#187419128 users should be able to view and update his/her profile #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| rejectValue: ProfileError; | ||
| } | ||
| >("profile/updateProfile", async (payload: FormData, { rejectWithValue }) => { | ||
| try { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
src/pages/updateProfile.tsx
Outdated
| </label> | ||
| </div> | ||
|
|
||
| <ProfileTextInput |
There was a problem hiding this comment.
Similar blocks of code found in 10 locations. Consider refactoring.
src/pages/updateProfile.tsx
Outdated
| name="fullName" | ||
| error={errors.fullName?.message} | ||
| /> | ||
| <ProfileTextInput |
There was a problem hiding this comment.
Similar blocks of code found in 10 locations. Consider refactoring.
src/pages/updateProfile.tsx
Outdated
| name="gender" | ||
| error={errors.gender?.message} | ||
| /> | ||
| <ProfileTextInput |
There was a problem hiding this comment.
Similar blocks of code found in 10 locations. Consider refactoring.
src/pages/updateProfile.tsx
Outdated
| name="birthdate" | ||
| error={errors.birthdate?.message} | ||
| /> | ||
| <ProfileTextInput |
There was a problem hiding this comment.
Similar blocks of code found in 10 locations. Consider refactoring.
niyobertin
requested review from
Heisjabo,
yvanddniyo,
dniwemugisha,
teerenzo,
Jovz19200,
MugemaneBertin2001 and
soleil00
niyobertin
force-pushed
the
ft-user-profile-#187419128
branch
from
9d33883 to
e0f3dfb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15 +/- ##
==========================================
+ Coverage 78.07% 78.86% +0.79%
==========================================
Files 49 56 +7
Lines 789 899 +110
Branches 85 95 +10
==========================================
+ Hits 616 709 +93
- Misses 171 188 +17
Partials 2 2 ☔ View full report in Codecov by Sentry. |
niyobertin
force-pushed
the
ft-user-profile-#187419128
branch
from
e0f3dfb to
90c2c64
Compare
niyobertin
force-pushed
the
ft-user-profile-#187419128
branch
from
90c2c64 to
530509d
Compare
niyobertin
force-pushed
the
ft-user-profile-#187419128
branch
from
530509d to
d7bc920
Compare
niyobertin
force-pushed
the
ft-user-profile-#187419128
branch
from
d7bc920 to
9c02cdf
Compare
niyobertin
force-pushed
the
ft-user-profile-#187419128
branch
from
9c02cdf to
e1df745
Compare
niyobertin
force-pushed
the
ft-user-profile-#187419128
branch
from
e1df745 to
25aa832
Compare
niyobertin
force-pushed
the
ft-user-profile-#187419128
branch
from
75f5709 to
b11d1f4
Compare
niyobertin
force-pushed
the
ft-user-profile-#187419128
branch
from
b11d1f4 to
f4fb310
Compare
niyobertin
force-pushed
the
ft-user-profile-#187419128
branch
from
f4fb310 to
b5be3dd
Compare
niyobertin
force-pushed
the
ft-user-profile-#187419128
branch
from
b5be3dd to
d7682e5
Compare
niyobertin
force-pushed
the
ft-user-profile-#187419128
branch
from
d7682e5 to
e76221c
Compare
niyobertin
force-pushed
the
ft-user-profile-#187419128
branch
from
e76221c to
95f2353
Compare
niyobertin
force-pushed
the
ft-user-profile-#187419128
branch
from
95f2353 to
b9da233
Compare
-Ensures that user can view his or her profile -Ensure that user can update his or her profile [Deliver #187419128]
niyobertin
force-pushed
the
ft-user-profile-#187419128
branch
from
b9da233 to
4089e8c
Compare
|
Code Climate has analyzed commit 4089e8c and detected 0 issues on this pull request. View more on Code Climate. |
teerenzo
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
User should be able to view or edit his/her profile
Description of Task to be completed?
Have users page to view the profile
Have form to edit profile
How should this be manually tested?
Clone the repo here cd into it .
checkout the branch ft-user-profile-#187419128
Then login to the system. and navigate to http://localhost:5173/profile
What are the relevant pivotal tracker/Trello stories?
#187419128 to see your profile
Screenshots (if appropriate)
User profile view design page
User Profile Figma
Edit Profile desigin page
Update profile figma
