Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#187419132--> product search #17

Merged
merged 5 commits into from
Jul 8, 2024
Merged

#187419132--> product search #17

merged 5 commits into from
Jul 8, 2024

Conversation

soleil00
Copy link
Collaborator

@soleil00 soleil00 commented Jul 2, 2024

what does this PR does

in this PR have adjusted search functionality to query product from db directly instead of querrying from prendered products

How this should be tested

  1. checkout to my branch fx-related-products
  2. run npm install to make sure u have updated dependencies
  3. spin up local server by running npm run dev
  4. go to product page and give it a try

Pivot tracker ----> #187419132

Screenshots

Screenshot 2024-07-02 at 17 50 39 Screenshot 2024-07-02 at 17 51 52 Screenshot 2024-07-04 at 15 26 46 Screenshot 2024-07-04 at 15 27 47

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eagles-ec-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 6:51pm

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 28.20513% with 28 lines in your changes missing coverage. Please review.

Project coverage is 72.34%. Comparing base (afb281e) to head (0259d3a).

Files Patch % Lines
src/redux/reducers/productsSlice.ts 10.34% 21 Missing and 5 partials ⚠️
src/components/cards/ProductCard.tsx 50.00% 1 Missing ⚠️
src/redux/reducers/categoriesSlice.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #17      +/-   ##
==========================================
- Coverage   74.00%   72.34%   -1.67%     
==========================================
  Files          63       63              
  Lines        1108     1139      +31     
  Branches      135      143       +8     
==========================================
+ Hits          820      824       +4     
- Misses        280      302      +22     
- Partials        8       13       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@niyobertin niyobertin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@MugemaneBertin2001 MugemaneBertin2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soleil00 soleil00 changed the title fix: product search #187419132-->fix: product search Jul 7, 2024
@soleil00 soleil00 changed the title #187419132-->fix: product search #187419132--> product search Jul 7, 2024
Copy link

codeclimate bot commented Jul 8, 2024

Code Climate has analyzed commit 39616fc and detected 0 issues on this pull request.

View more on Code Climate.

@teerenzo teerenzo merged commit b2fcb6c into dev Jul 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants