Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#187419141 buyer should be able to dd product to wish list. #26

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

niyobertin
Copy link
Collaborator

What does this PR do?

Adding and removing wishes to a wish list

Description of Task to be completed?

Buyer should be able :

  • Add wish on a products
  • Remove wish on a products
  • and read a wish on a products

Seller should be able to view all wishes made on his/her products

How should this be manually tested?

Crone the repo, cd into it, the run:

  • npm install : to install the dependencies
  • npm run dev : to start the server

Add products to the wish list by clicking on heart Icone.
If you click on it again that means you removed a wish from that product.

Navigate to the wish list you will find the list of all wishes you made.

What are the relevant pivotal tracker/Trello stories?

#187419141

Screenshots (if appropriate)

The Products with heart Icons in red background color are added to a wish list and the rest not.
Screenshot 2024-07-20 at 17 51 18

Buyer wishes list
Screenshot 2024-07-20 at 17 51 35

Seller's Products under wish list.
Screenshot 2024-07-20 at 17 51 47

Copy link

vercel bot commented Jul 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eagles-ec-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 8:58am

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 70.08547% with 35 lines in your changes missing coverage. Please review.

Project coverage is 73.16%. Comparing base (f306d90) to head (875a081).
Report is 2 commits behind head on dev.

Files Patch % Lines
src/components/cards/ProductCard.tsx 38.29% 27 Missing and 2 partials ⚠️
src/redux/reducers/wishListSlice.ts 95.16% 3 Missing ⚠️
src/pages/userProfile.tsx 33.33% 2 Missing ⚠️
src/redux/reducers/reviewSlice.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #26      +/-   ##
==========================================
+ Coverage   72.81%   73.16%   +0.35%     
==========================================
  Files          75       76       +1     
  Lines        1703     1815     +112     
  Branches      250      269      +19     
==========================================
+ Hits         1240     1328      +88     
- Misses        445      467      +22     
- Partials       18       20       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

-Buyer should wish a products
-Buyer should add a wished products to cart
-Seller should be able to see a wished products

[Deliver #187419141]
Copy link
Collaborator

@MugemaneBertin2001 MugemaneBertin2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

-Buyer should wish a products
-Buyer should add a wished products to cart
-Seller should be able to see a wished products

[Deliver #187419141]
@niyobertin niyobertin force-pushed the ft-wishes-#187419141 branch from f995e54 to 875a081 Compare July 24, 2024 08:58
Copy link

codeclimate bot commented Jul 24, 2024

Code Climate has analyzed commit 875a081 and detected 0 issues on this pull request.

View more on Code Climate.

@teerenzo teerenzo merged commit 5b1bd21 into dev Jul 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants