Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#187984455 header navigation #27

Merged
merged 1 commit into from
Jul 26, 2024
Merged

#187984455 header navigation #27

merged 1 commit into from
Jul 26, 2024

Conversation

Heisjabo
Copy link
Collaborator

@Heisjabo Heisjabo commented Jul 25, 2024

What does this PR do?

This PR Adds improved header navigation

Description of Task to be completed?

  • improved existing header navigation
  • make the navigation responsive in mobile
  • add profile dropdown for site navigation

How should this be manually tested?

  1. Clone the repository.
  2. Checkout to the branch ft-header-nav-#187984455.
  3. Run npm install to install dependencies.
  4. Run npm run dev to start the development server
  5. Access the app on http://localhost:5173/

What are the relevant pivotal tracker stories?

Delivers #187984455

screenshots

Screenshot 2024-07-26 at 9 44 30 AM Screenshot 2024-07-26 at 9 48 32 AM Screenshot 2024-07-26 at 9 48 40 AM Screenshot 2024-07-26 at 9 44 55 AM

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eagles-ec-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 2:21pm

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 63.82979% with 17 lines in your changes missing coverage. Please review.

Project coverage is 73.47%. Comparing base (a60a1e6) to head (ecd5111).

Files Patch % Lines
src/components/common/ProfileDropdown.tsx 25.00% 9 Missing ⚠️
src/components/dashboard/Header.tsx 63.15% 6 Missing and 1 partial ⚠️
src/redux/api/api.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #27      +/-   ##
==========================================
- Coverage   73.87%   73.47%   -0.40%     
==========================================
  Files          81       82       +1     
  Lines        1952     1987      +35     
  Branches      284      303      +19     
==========================================
+ Hits         1442     1460      +18     
- Misses        488      504      +16     
- Partials       22       23       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- improve existing header navigation
- make the navigation responsive in mobile
- add profile dropdown for site navigation

Delivers #187984455
@Heisjabo Heisjabo force-pushed the ft-header-nav-#187984455 branch from 86e41b9 to ecd5111 Compare July 26, 2024 14:20
Copy link

codeclimate bot commented Jul 26, 2024

Code Climate has analyzed commit ecd5111 and detected 0 issues on this pull request.

View more on Code Climate.

@teerenzo teerenzo merged commit 1186659 into dev Jul 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants