Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User: Auth logout #187984515 #35

Merged
merged 1 commit into from
Jul 30, 2024
Merged

User: Auth logout #187984515 #35

merged 1 commit into from
Jul 30, 2024

Conversation

MugemaneBertin2001
Copy link
Collaborator

What does this PR do?

This PR Adds Logout feature in eagle-ec-fe

Description of Task to be completed?

  • Remove the access token from local storage
  • To blacklist used accesstoken

How should this be manually tested?

  1. Clone the repository.
  2. Checkout to the branch ft-user-logout-#187984515.
  3. Run npm install to install dependencies.
  4. Run npm run dev to start the development server
  5. Access the app on http://localhost:5173/
  6. Log into your account
  7. Logout using logout button on bottom of sidebar

What are the relevant pivotal tracker stories?

Delivers #187984515

Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eagles-ec-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 2:24pm

Copy link

gitguardian bot commented Jul 30, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
7139998 Triggered Generic Password c62ea67 src/test/login.test.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 74.16667% with 31 lines in your changes missing coverage. Please review.

Project coverage is 74.39%. Comparing base (968b444) to head (c62ea67).
Report is 3 commits behind head on dev.

Files Patch % Lines
src/pages/Login.tsx 13.33% 13 Missing ⚠️
src/components/dashboard/Header.tsx 37.50% 4 Missing and 1 partial ⚠️
src/components/dashboard/admin/LogoutContext.tsx 84.37% 5 Missing ⚠️
src/redux/ProtectDashboard.tsx 76.47% 4 Missing ⚠️
src/redux/api/api.ts 50.00% 3 Missing ⚠️
src/components/dashboard/HomeButton.tsx 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #35      +/-   ##
==========================================
+ Coverage   74.09%   74.39%   +0.29%     
==========================================
  Files          83       87       +4     
  Lines        2027     2121      +94     
  Branches      306      324      +18     
==========================================
+ Hits         1502     1578      +76     
- Misses        514      531      +17     
- Partials       11       12       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MugemaneBertin2001 MugemaneBertin2001 force-pushed the ft-user-logout-#187984515 branch from 764e691 to f299ea1 Compare July 30, 2024 12:22
@MugemaneBertin2001 MugemaneBertin2001 changed the title User: this pr enables user to logout from one's session #187984515 User: User logout #187984515 Jul 30, 2024
@MugemaneBertin2001 MugemaneBertin2001 changed the title User: User logout #187984515 User: Auth logout #187984515 Jul 30, 2024
Copy link
Collaborator

@soleil00 soleil00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MugemaneBertin2001 MugemaneBertin2001 force-pushed the ft-user-logout-#187984515 branch from e4ed710 to c62ea67 Compare July 30, 2024 14:23
Copy link

codeclimate bot commented Jul 30, 2024

Code Climate has analyzed commit c62ea67 and detected 0 issues on this pull request.

View more on Code Climate.

@teerenzo teerenzo merged commit a44d64b into dev Jul 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants