Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix users chat #36

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix users chat #36

merged 1 commit into from
Jul 30, 2024

Conversation

Heisjabo
Copy link
Collaborator

What does this PR do?

This PR fixes private chat to receive messages in realtime

Description of Task to be completed?

  • a user should be able to receive private messages in real time without joining any room

How should this be manually tested?

  1. Clone the repository.
  2. Checkout to the branch fix-chat.
  3. Run npm install to install dependencies.
  4. Run npm run dev to start the development server and login two different users
  5. navigate to /chat
  6. Test if a message is being received while not in the private chat room

Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eagles-ec-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 4:31pm

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.75%. Comparing base (077f5d2) to head (a4e578d).

Files Patch % Lines
src/page-sections/UserList.tsx 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #36      +/-   ##
==========================================
+ Coverage   74.72%   74.75%   +0.03%     
==========================================
  Files          88       88              
  Lines        2160     2167       +7     
  Branches      328      331       +3     
==========================================
+ Hits         1614     1620       +6     
+ Misses        534      522      -12     
- Partials       12       25      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codeclimate bot commented Jul 30, 2024

Code Climate has analyzed commit a4e578d and detected 0 issues on this pull request.

View more on Code Climate.

@teerenzo teerenzo merged commit 6deee64 into dev Jul 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants