ft: product visibility-#187419124 #8
Conversation
#187419120 Users should be able to Login with Email and Password
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| <div className="w-full bg-black text-white p-4"> | ||
| <div className="max-w-[1440px] w-[90%] mx-auto py-5"> | ||
| <Grid container spacing={4}> | ||
| <Grid item xs={12} sm={6} md={3}> |
There was a problem hiding this comment.
Similar blocks of code found in 4 locations. Consider refactoring.
| <Typography variant="body2">+250 780 693 425</Typography> | ||
| <Typography variant="body2">[email protected]</Typography> | ||
| </Grid> | ||
| <Grid item xs={12} sm={6} md={3}> |
There was a problem hiding this comment.
Similar blocks of code found in 4 locations. Consider refactoring.
| <Typography variant="body2">Mobile phones & accessories</Typography> | ||
| <Typography variant="body2">Home Furnitures</Typography> | ||
| </Grid> | ||
| <Grid item xs={12} sm={6} md={3}> |
There was a problem hiding this comment.
Similar blocks of code found in 4 locations. Consider refactoring.
| <Typography variant="body2">Contact</Typography> | ||
| <Typography variant="body2">Forum</Typography> | ||
| </Grid> | ||
| <Grid item xs={12} sm={6} md={3}> |
There was a problem hiding this comment.
Similar blocks of code found in 4 locations. Consider refactoring.
| Featured Products | ||
| </Typography> | ||
|
|
||
| <Grid |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
|
||
| const ProductPageSkeleton = () => ( | ||
| <div> | ||
| <Grid |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| <span className="ml-2 font-semibold text-[15px]">$150.00</span> | ||
| </Stack> | ||
| </Stack> | ||
| <Stack direction="row" className="flex items-center"> |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| animation="wave" | ||
| /> | ||
|
|
||
| <div className=" absolute top-0 right-0 p-0 "> |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| )} | ||
| </div> | ||
|
|
||
| <div className=" absolute top-0 right-0 p-0 "> |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| <Stack | ||
| direction="row" | ||
| className="flex justify-between items-center gap-2 bg-white" | ||
| > |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
soleil00
force-pushed
the
ft-product-display-##187419124
branch
from
9002292 to
af07164
Compare
| <FaLinkedinIn /> | ||
| </NavLink> | ||
| </div> | ||
| <div className="border-t border-gray-700 mt-6 pt-4 text-center"> |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
|
||
| if (data?.lenght < 1) { | ||
| return ( | ||
| <div className="my-5 px-4"> |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
src/__test__/productFilter.tsx
Outdated
|
|
||
| fireEvent.click(screen.getByLabelText("Price: Low to high")); | ||
|
|
||
| expect(onFilter).toHaveBeenCalledWith([ |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
src/__test__/productFilter.tsx
Outdated
|
|
||
| fireEvent.click(screen.getByLabelText("Price: High to low")); | ||
|
|
||
| expect(onFilter).toHaveBeenCalledWith([ |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| </div> | ||
|
|
||
| <div className="rounded-md p-2"> | ||
| <div className="p-2 flex items-center gap-2"> |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| alignItems="center" | ||
| className="mb-4" | ||
| > | ||
| {currentItems.map((product) => ( |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| alignItems="center" | ||
| className="mb-4" | ||
| > | ||
| {products?.slice(0, 8).map((product: IProduct) => ( |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| </div> | ||
| </div> | ||
| <Divider /> | ||
| <div className="p-2 flex items-center gap-2"> |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
src/__test__/featureprod.tsx
Outdated
| }); | ||
| }); | ||
|
|
||
| it("should render loading skeleton while fetching products", () => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
src/__test__/featureprod.tsx
Outdated
| }); | ||
| }); | ||
|
|
||
| it('should render "no product found" message when data is empty', () => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
soleil00
requested review from
MugemaneBertin2001,
teerenzo,
niyobertin,
Jovz19200,
Heisjabo and
yvanddniyo
soleil00
force-pushed
the
ft-product-display-##187419124
branch
from
b64cdfa to
2633c08
Compare
| </Stack> | ||
| <Divider /> | ||
|
|
||
| <div className="flex justify-between items-center"> |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| onFilter: (filteredProducts: IProduct[]) => void; | ||
| } | ||
|
|
||
| const priceRanges = [ |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
src/__test__/productFilter.tsx
Outdated
|
|
||
| import dummyProducts from "./__mock__/product"; | ||
|
|
||
| const priceRanges = [ |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
|
||
| describe("Testing React components", () => { | ||
| it("should render home page components", () => { | ||
| render( |
There was a problem hiding this comment.
Similar blocks of code found in 9 locations. Consider refactoring.
|
|
||
| describe("Testing AdvertisedCategory Component", () => { | ||
| it("should render advertised category section", () => { | ||
| render( |
There was a problem hiding this comment.
Similar blocks of code found in 9 locations. Consider refactoring.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #8 +/- ##
==========================================
+ Coverage 77.35% 78.07% +0.71%
==========================================
Files 42 49 +7
Lines 711 789 +78
Branches 76 85 +9
==========================================
+ Hits 550 616 +66
- Misses 159 171 +12
Partials 2 2 ☔ View full report in Codecov by Sentry. |
soleil00
force-pushed
the
ft-product-display-##187419124
branch
from
04243b9 to
81f1cd2
Compare
soleil00
force-pushed
the
ft-product-display-##187419124
branch
from
d01b744 to
d105a6a
Compare
soleil00
force-pushed
the
ft-product-display-##187419124
branch
from
d105a6a to
2d7dd24
Compare
|
Code Climate has analyzed commit 2d7dd24 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 12081800 | Triggered | Generic Password | b01e7f7 | src/test/updatePasswordApiSlice.test.tsx | View secret |
| 12081800 | Triggered | Generic Password | b01e7f7 | src/test/updatePasswordApiSlice.test.tsx | View secret |
| 12081800 | Triggered | Generic Password | b01e7f7 | src/test/updatePasswordApiSlice.test.tsx | View secret |
| 12081800 | Triggered | Generic Password | b01e7f7 | src/test/updatePasswordApiSlice.test.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
ft: product visibility-#187419124
ft: product visibility-#187419124
ft: product visibility-#187419124
ft: product visibility-#187419124
ft: product visibility-#187419124
ft: product visibility-#187419124
ft: product visibility-#187419124
ft: product visibility-#187419124
ft: product visibility-#187419124
ft: product visibility-#187419124
What does this PR do?
in this PR i added product visibility allowing user to see products when he visit th ewebsit
Description of Task to be completed?
How should this be manually tested?
npm installto install dependencies./or/productsWhat are the relevant pivotal tracker stories?
Delivers #187419124
Screenshots