Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve name conflict on node-webkit #311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yapcheahshen
Copy link

use requirejs() instead of require() for running on node-webkit.

@sbellity
Copy link
Member

sbellity commented Sep 5, 2013

@yapcheahshen the tests seem to fail.

https://travis-ci.org/aurajs/aura/jobs/11012559

Can you fix this ?

Thanks !

@sbellity
Copy link
Member

sbellity commented Sep 5, 2013

@yapcheahshen Very curious to see it running on node-webkit !
Do you have a demo to share ;) ?

@yapcheahshen
Copy link
Author

i built this platform , write and test on node-webkit,
and deploy to server right away.
https://github.com/yapcheahshen/ksanapc

On Thu, Sep 5, 2013 at 7:54 PM, Stephane Bellity
[email protected]:

@yapcheahshen https://github.com/yapcheahshen Very curious to see it
running on node-webkit !
Do you have a demo to share ;) ?


Reply to this email directly or view it on GitHubhttps://github.com//pull/311#issuecomment-23862239
.

@yapcheahshen
Copy link
Author

it seems like https://travis-ci.org/aurajs/aura/jobs/11012559 doesn't have "requirejs"
I am using RequireJS 2.0.2 with node-webkit,
on node-webkit, require() is node.js CommonJS ,
on browser side need to use requirejs() for AMD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants