Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes context override #417

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fixes context override #417

merged 1 commit into from
Sep 18, 2024

Conversation

vroldanbet
Copy link
Contributor

A customer reported flags being ignored even when
they were being provided via CLI arguments.

The behavior of overriding current context via
CLI arguments was inconsistent across the codebase. This centralizes the logic so all the various commands use the same logic.

@vroldanbet vroldanbet self-assigned this Sep 18, 2024
A customer reported flags being ignored even when
they were being provided via CLI arguments.

The behavior of overriding current context via
CLI arguments was inconsistent across the codebase.
This centralizes the logic so all the various commands
use the same logic.
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I had a couple of questions but it's "how does this work" stuff. Thank you for the tests!

internal/storage/config.go Show resolved Hide resolved
internal/storage/config.go Show resolved Hide resolved
@vroldanbet vroldanbet merged commit af2bed5 into main Sep 18, 2024
15 checks passed
@vroldanbet vroldanbet deleted the fix-context-override branch September 18, 2024 19:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants