Add --force-color flag to zed validate #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vroldanbet
reviewed
Nov 7, 2024
internal/cmd/validate.go
Outdated
| setForceColor := cobrautil.MustGetBool(cmd, "force-color") | ||
| if setForceColor { | ||
| lipgloss.SetColorProfile(termenv.ANSI256) | ||
| fmt.Println(lipgloss.DefaultRenderer().ColorProfile() == termenv.ANSI256) |
There was a problem hiding this comment.
why the need to print here?
| traceStyle = lipgloss.NewStyle().Bold(true) | ||
| // NOTE: these need to be set *after* the renderer has been set, otherwise | ||
| // the forceColor setting can't work, hence the thunking. | ||
| success = func() string { |
There was a problem hiding this comment.
what's the cost of initializing this each time? alternatively, these could be left as uninitialized vars, and initialize them after we've checked the flag
There was a problem hiding this comment.
I thought about that, but that spreads the definitions around the file, and some of the definitions are used by multiple functions. I don't think it's particularly expensive, though that isn't because I've profiled it.
vroldanbet
previously approved these changes
Nov 7, 2024
ecordell
approved these changes
Nov 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #434
Description
See #434. There are non-terminal environments (e.g. some CI environments) that support color, but
lipglossassumes that a non-terminal environment is uncolored. This provides a--force-colorflag that allows the user to override this behavior and get color output forzed validate, which is the only place we're usinglipgloss.Changes
PreRunEthat interprets the flagDefaultRendererTesting
Review. See that things are green. The way that I was able to test this locally was comparing:
Where the command is run from a folder that has a built
zedbinary.