Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commented out unicode error logging #1145

Closed
wants to merge 1 commit into from
Closed

Commented out unicode error logging #1145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions donkeycar/parts/serial_port.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def read(self, count:int=0) -> Tuple[bool, str]:
try:
return (ok, bytestring.decode(self.charset))
except UnicodeDecodeError:
# the first read often includes mis-framed garbase
# the first read often includes mis-framed garbage
return (False, "")

def readln(self) -> Tuple[bool, str]:
Expand Down Expand Up @@ -139,7 +139,7 @@ def readln(self) -> Tuple[bool, str]:
return (False, "")
except UnicodeDecodeError:
# the first read often includes mis-framed garbase
logger.warn("failed decoding unicode line from serial port")
# logger.warn("failed decoding unicode line from serial port")
return (False, "")

def writeBytes(self, value:bytes):
Expand Down